Skip to content

Conversation

@RoyLee1224
Copy link
Contributor

Related

part of: #56250
related:#56216

Why

The log highlight color is extremely low contrast.

Notes

  • Open to all feedback — if you have a preferred color or another suggestion, feel free to comment.
  • Should we also update the Code tab highlight (for consistency) at the same time?

Sceenshots

dark before

dark_before

dark after

dark_after

light before

light_before

light after

 light_after

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Oct 3, 2025
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is improving on top of current main which already had changed recently. Would like s econd opinion from one of the other core UI maintainers before we flip the code too often.

@jscheffl jscheffl added this to the Airflow 3.1.1 milestone Oct 4, 2025
@jscheffl jscheffl added the type:bug-fix Changelog: Bug Fixes label Oct 4, 2025
Copy link
Member

@guan404ming guan404ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color wise looks good to me.
How about let move the change into <Code> to remain the UI consistency?

@bbovenzi bbovenzi merged commit 235d6f8 into apache:main Oct 16, 2025
57 checks passed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
* style: modify log highlight color

* style: modify code highlight color
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
* style: modify log highlight color

* style: modify code highlight color
@RoyLee1224 RoyLee1224 deleted the log-highlight-color branch October 20, 2025 00:24
pierrejeambrun pushed a commit to astronomer/airflow that referenced this pull request Oct 20, 2025
* style: modify log highlight color

* style: modify code highlight color

(cherry picked from commit 235d6f8)
@pierrejeambrun
Copy link
Member

Manual backport: #56894
cc: @bbovenzi

pierrejeambrun pushed a commit to astronomer/airflow that referenced this pull request Oct 21, 2025
* style: modify log highlight color

* style: modify code highlight color

(cherry picked from commit 235d6f8)
pierrejeambrun added a commit that referenced this pull request Oct 21, 2025
* style: modify log highlight color

* style: modify code highlight color

(cherry picked from commit 235d6f8)

Co-authored-by: LI,JHE-CHEN <[email protected]>
TyrellHaywood pushed a commit to TyrellHaywood/airflow that referenced this pull request Oct 22, 2025
* style: modify log highlight color

* style: modify code highlight color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants