-
Notifications
You must be signed in to change notification settings - Fork 15.9k
style: modify log highlight color #56379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is improving on top of current main which already had changed recently. Would like s econd opinion from one of the other core UI maintainers before we flip the code too often.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Color wise looks good to me.
How about let move the change into <Code> to remain the UI consistency?
* style: modify log highlight color * style: modify code highlight color
* style: modify log highlight color * style: modify code highlight color
* style: modify log highlight color * style: modify code highlight color (cherry picked from commit 235d6f8)
* style: modify log highlight color * style: modify code highlight color (cherry picked from commit 235d6f8)
* style: modify log highlight color * style: modify code highlight color (cherry picked from commit 235d6f8) Co-authored-by: LI,JHE-CHEN <[email protected]>
* style: modify log highlight color * style: modify code highlight color
Related
part of: #56250
related:#56216
Why
Notes
Codetab highlight (for consistency) at the same time?Sceenshots
dark before
dark after
light before
light after
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.