Fix scheduler crash during 3.0 to 3.1 migration when retry_delay is None #56202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
cc @kaxil |
Member
|
@dheerajturaga Could you post steps to reproduce it, please? |
kaxil
reviewed
Sep 29, 2025
kaxil
reviewed
Sep 29, 2025
dheerajturaga
force-pushed
the
bugfix/scheduler-crash-3_0-to-3_1
branch
from
11533cb to
3176369
Compare
dheerajturaga
requested review from
gopidesupavan and
potiuk
as code owners
kaxil
reviewed
Sep 29, 2025
kaxil
approved these changes
Sep 30, 2025
kaxil
added
the
backport-to-v3-1-test
Contributor
Author
|
@kaxil , Thanks for fixing the tests! |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2025
…y_delay is None (#56202) * Kaxil's suggestions * make default a float because some tests are complaining * Fix test * fixup! Fix test * fixup! fixup! Fix test --------- (cherry picked from commit 1f976d0) Co-authored-by: Dheeraj Turaga <[email protected]> Co-authored-by: Kaxil Naik <[email protected]>
Backport successfully created: v3-1-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Sep 30, 2025
…y_delay is None (apache#56202) * Kaxil's suggestions * make default a float because some tests are complaining * Fix test * fixup! Fix test * fixup! fixup! Fix test --------- (cherry picked from commit 1f976d0) Co-authored-by: Dheeraj Turaga <[email protected]> Co-authored-by: Kaxil Naik <[email protected]>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
…one (apache#56202) * Kaxil's suggestions * make default a float because some tests are complaining * Fix test * fixup! Fix test * fixup! fixup! Fix test --------- Co-authored-by: Kaxil Naik <[email protected]>
kaxil
added a commit
that referenced
this pull request
Oct 1, 2025
…y_delay is None (#56202) (#56236) --------- (cherry picked from commit 1f976d0) Co-authored-by: Dheeraj Turaga <[email protected]> Co-authored-by: Kaxil Naik <[email protected]>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
…one (apache#56202) * Kaxil's suggestions * make default a float because some tests are complaining * Fix test * fixup! Fix test * fixup! fixup! Fix test --------- Co-authored-by: Kaxil Naik <[email protected]>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
…one (apache#56202) * Kaxil's suggestions * make default a float because some tests are complaining * Fix test * fixup! Fix test * fixup! fixup! Fix test --------- Co-authored-by: Kaxil Naik <[email protected]>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
…one (apache#56202) * Kaxil's suggestions * make default a float because some tests are complaining * Fix test * fixup! Fix test * fixup! fixup! Fix test --------- Co-authored-by: Kaxil Naik <[email protected]>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
…one (apache#56202) * Kaxil's suggestions * make default a float because some tests are complaining * Fix test * fixup! Fix test * fixup! fixup! Fix test --------- Co-authored-by: Kaxil Naik <[email protected]>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
…one (apache#56202) * Kaxil's suggestions * make default a float because some tests are complaining * Fix test * fixup! Fix test * fixup! fixup! Fix test --------- Co-authored-by: Kaxil Naik <[email protected]>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
…one (apache#56202) * Kaxil's suggestions * make default a float because some tests are complaining * Fix test * fixup! Fix test * fixup! fixup! Fix test --------- Co-authored-by: Kaxil Naik <[email protected]>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
…one (apache#56202) * Kaxil's suggestions * make default a float because some tests are complaining * Fix test * fixup! Fix test * fixup! fixup! Fix test --------- Co-authored-by: Kaxil Naik <[email protected]>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
…one (apache#56202) * Kaxil's suggestions * make default a float because some tests are complaining * Fix test * fixup! Fix test * fixup! fixup! Fix test --------- Co-authored-by: Kaxil Naik <[email protected]>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
…one (apache#56202) * Kaxil's suggestions * make default a float because some tests are complaining * Fix test * fixup! Fix test * fixup! fixup! Fix test --------- Co-authored-by: Kaxil Naik <[email protected]>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
…one (apache#56202) * Kaxil's suggestions * make default a float because some tests are complaining * Fix test * fixup! Fix test * fixup! fixup! Fix test --------- Co-authored-by: Kaxil Naik <[email protected]>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
…one (apache#56202) * Kaxil's suggestions * make default a float because some tests are complaining * Fix test * fixup! Fix test * fixup! fixup! Fix test --------- Co-authored-by: Kaxil Naik <[email protected]>
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Oct 12, 2025
…one (apache#56202) * Kaxil's suggestions * make default a float because some tests are complaining * Fix test * fixup! Fix test * fixup! fixup! Fix test --------- Co-authored-by: Kaxil Naik <[email protected]>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
…one (apache#56202) * Kaxil's suggestions * make default a float because some tests are complaining * Fix test * fixup! Fix test * fixup! fixup! Fix test --------- Co-authored-by: Kaxil Naik <[email protected]>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
…one (apache#56202) * Kaxil's suggestions * make default a float because some tests are complaining * Fix test * fixup! Fix test * fixup! fixup! Fix test --------- Co-authored-by: Kaxil Naik <[email protected]>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
…one (apache#56202) * Kaxil's suggestions * make default a float because some tests are complaining * Fix test * fixup! Fix test * fixup! fixup! Fix test --------- Co-authored-by: Kaxil Naik <[email protected]>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
…one (apache#56202) * Kaxil's suggestions * make default a float because some tests are complaining * Fix test * fixup! Fix test * fixup! fixup! Fix test --------- Co-authored-by: Kaxil Naik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During migration from Airflow 3.0 to 3.1, some task instances may have
retry_delay set to None due to serialization/deserialization changes or
database migration issues. This causes the scheduler to crash with:
TypeError: unsupported operand type(s) for +: 'datetime.datetime' and 'NoneType'
The error occurs in TaskInstance.next_retry_datetime() when attempting to
add a None retry_delay to end_date.
Related: Airflow 3.0 to 3.1 migration compatibility