Better handling masking of values of set variable #43123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamraj-git
force-pushed
the
mask-issue
branch
3 times, most recently
from
f5370e2 to
2ca34f1
Compare
amoghrajesh
reviewed
Oct 18, 2024
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Good work @shubhamraj-git
I have a few comments
Contributor
|
Test failures look unrelated, but the static checks needs fixing. |
shubhamraj-git
force-pushed
the
mask-issue
branch
from
0eebf9f to
9a02986
Compare
amoghrajesh
approved these changes
Oct 22, 2024
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Left a nit, preemptive approval assuming the change will be made +1
The test failure looks to be unrelated, retriggering.
shubhamraj-git
force-pushed
the
mask-issue
branch
from
9a02986 to
a938ac4
Compare
potiuk
approved these changes
Oct 22, 2024
potiuk
pushed a commit
to potiuk/airflow
that referenced
this pull request
Oct 22, 2024
(cherry picked from commit 1260d9c)
potiuk
added a commit
that referenced
this pull request
Oct 23, 2024
(cherry picked from commit 1260d9c) Co-authored-by: Shubham Raj <[email protected]>
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 23, 2024
(cherry picked from commit 1260d9c) Co-authored-by: Shubham Raj <[email protected]>
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 24, 2024
(cherry picked from commit 1260d9c) Co-authored-by: Shubham Raj <[email protected]>
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better handling masking of values of set variable
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.