Skip to content

[SOL] New encoding for memory instructions #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LucasSte merged 1 commit into from
Dec 16, 2024
Merged

[SOL] New encoding for memory instructions #118

LucasSte merged 1 commit into from
Dec 16, 2024

Conversation

@LucasSte
Copy link
Collaborator

@LucasSte LucasSte commented Dec 13, 2024 •
edited by Lichtso
Loading

SIMD-0173 introduces a new encoding for memory instructions, as follows:

STB  => 0x27 
STH  => 0x37
STW  => 0x87
STDW => 0x97

SDXB  => 0x2f
SDXH  => 0x3f
SDXW  => 0x8f
SDXDW => 0x9f

LDXB  => 0x2c 
LDXH  => 0x3c
LDXW  => 0x8c
LDXDW => 0x9c

This PR brings this new encoding to the SBF target.

@LucasSte LucasSte requested a review from dmakarov December 13, 2024 18:14
@LucasSte LucasSte marked this pull request as ready for review December 13, 2024 18:14
@dmakarov dmakarov requested a review from Lichtso December 13, 2024 21:59
Lichtso
Lichtso reviewed Dec 16, 2024
View reviewed changes
Lichtso
Lichtso reviewed Dec 16, 2024
View reviewed changes
Lichtso
Lichtso reviewed Dec 16, 2024
View reviewed changes
Lichtso
Lichtso reviewed Dec 16, 2024
View reviewed changes
@LucasSte LucasSte merged commit dda6181 into anza-xyz:solana-rustc/18.1-2024-05-19 Dec 16, 2024
15 checks passed
@LucasSte LucasSte deleted the mem-enc branch December 16, 2024 17:16
LucasSte added a commit to LucasSte/llvm-project that referenced this pull request Feb 13, 2025
@LucasSte
[SOL] New encoding for memory instructions (anza-xyz#118)
122b513
LucasSte added a commit that referenced this pull request Apr 8, 2025
@LucasSte
[SOL] New encoding for memory instructions (#118)
3f0dbe4
LucasSte added a commit to LucasSte/llvm-project that referenced this pull request Aug 12, 2025
@LucasSte
[SOL] New encoding for memory instructions (anza-xyz#118)
b5b90fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lichtso Lichtso Lichtso approved these changes

@dmakarov dmakarov Awaiting requested review from dmakarov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LucasSte @Lichtso