refactor: rename BLSMessage to ConsensusMessage#413
Merged
Conversation
akhi3030
force-pushed
the
akhi3030/consensus-message
branch
6 times, most recently
from
e64dc17 to
f907485
Compare
akhi3030
force-pushed
the
akhi3030/consensus-message
branch
from
f907485 to
6d6afe2
Compare
wen-coding
reviewed
Aug 21, 2025
AshwinSekar
reviewed
Aug 21, 2025
Contributor
AshwinSekar
left a comment
AshwinSekar
left a comment
There was a problem hiding this comment.
LGTM, pending conclusion of wen's issue
wen-coding
reviewed
Aug 21, 2025
| root_bank_cache, | ||
| verified_vote_sender.clone(), | ||
| bls_verified_message_sender, | ||
| consensus_message_sender, |
Contributor
There was a problem hiding this comment.
The incoming messages are also of type ConsensusMessage, I do prefer to keep verified in the name here.
| | Self::WaitToVoteSlot(_) | ||
| | Self::NoRankFound => false, | ||
| Self::Tx(_) | Self::BLSMessage(_) => false, | ||
| Self::Tx(_) | Self::Consensus(_) => false, |
Contributor
There was a problem hiding this comment.
Why is this Consensus instead of ConsensusMessage?
Contributor
Author
There was a problem hiding this comment.
I thought it was a bit verbose. Updated in 5fcf524.
Contributor
There was a problem hiding this comment.
LGTM, can approve after conflicts are resolved.
Contributor
Author
There was a problem hiding this comment.
Merged the latest master into the branch and resolved the conflicts.
wen-coding
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
BLS happens to be implementation detail. It should not be captured in the name of the message.
Summary of Changes
Renames
BLSMessagetoConsensusMessageFixes #
Closes #365.