v3.1: svm: properly test underfunded nonce fee-payer (backport of #9246)#9849
Merged
v3.1: svm: properly test underfunded nonce fee-payer (backport of #9246)#9849
Conversation
Author
|
Cherry-pick of af5d4e8 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Member
|
@Mergifyio rebase |
Author
☑️ Nothing to do, the required conditions are not metDetails
|
b6f9697 to
81c828e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.1 #9849 +/- ##
=======================================
Coverage 83.2% 83.2%
=======================================
Files 865 865
Lines 376085 376097 +12
=======================================
+ Hits 313092 313122 +30
+ Misses 62993 62975 -18 🚀 New features to boost your workflow:
|
t-nelson
approved these changes
Jan 9, 2026
buffalojoec
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
the "Insufficient Fees" branch of
test_validate_transaction_fee_payer_is_nonce()does not actually set up aNonceInfoonCheckedTransactionDetails, so the nonce account is tested as an ordinary fee-payerthis isnt really a gap in test coverage now since the two validation steps are functionally independent, but the interrelationship is crucial for simd290/simd297
Summary of Changes
create a valid nonce nonce account and
NonceInfoso we properly go through this code pathThis is an automatic backport of pull request #9246 done by Mergify.