Skip to content

v3.1: svm: properly test underfunded nonce fee-payer (backport of #9246)#9849

Merged
2501babe merged 1 commit intov3.1from
mergify/bp/v3.1/pr-9246
Jan 10, 2026
Merged

v3.1: svm: properly test underfunded nonce fee-payer (backport of #9246)#9849
2501babe merged 1 commit intov3.1from
mergify/bp/v3.1/pr-9246

Conversation

@mergify
Copy link

@mergify mergify bot commented Jan 7, 2026

Problem

the "Insufficient Fees" branch of test_validate_transaction_fee_payer_is_nonce() does not actually set up a NonceInfo on CheckedTransactionDetails, so the nonce account is tested as an ordinary fee-payer

this isnt really a gap in test coverage now since the two validation steps are functionally independent, but the interrelationship is crucial for simd290/simd297

Summary of Changes

create a valid nonce nonce account and NonceInfo so we properly go through this code path


This is an automatic backport of pull request #9246 done by Mergify.

@mergify mergify bot added the conflicts label Jan 7, 2026
@mergify mergify bot requested a review from a team as a code owner January 7, 2026 19:50
@mergify mergify bot added the conflicts label Jan 7, 2026
@mergify
Copy link
Author

mergify bot commented Jan 7, 2026

Cherry-pick of af5d4e8 has failed:

On branch mergify/bp/v3.1/pr-9246
Your branch is up to date with 'origin/v3.1'.

You are currently cherry-picking commit af5d4e8b4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   svm/src/transaction_processor.rs

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@2501babe
Copy link
Member

2501babe commented Jan 9, 2026

@Mergifyio rebase

@mergify
Copy link
Author

mergify bot commented Jan 9, 2026

rebase

☑️ Nothing to do, the required conditions are not met

Details
  • -conflict [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]
  • any of:
    • #commits-behind > 0 [📌 rebase requirement]
    • #commits > 1 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]

@2501babe 2501babe force-pushed the mergify/bp/v3.1/pr-9246 branch from b6f9697 to 81c828e Compare January 9, 2026 08:58
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.2%. Comparing base (a49b7c8) to head (81c828e).

Additional details and impacted files
@@           Coverage Diff           @@
##             v3.1    #9849   +/-   ##
=======================================
  Coverage    83.2%    83.2%           
=======================================
  Files         865      865           
  Lines      376085   376097   +12     
=======================================
+ Hits       313092   313122   +30     
+ Misses      62993    62975   -18     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@2501babe 2501babe marked this pull request as ready for review January 9, 2026 10:03
@2501babe 2501babe removed the conflicts label Jan 9, 2026
@2501babe 2501babe merged commit 4857876 into v3.1 Jan 10, 2026
45 checks passed
@2501babe 2501babe deleted the mergify/bp/v3.1/pr-9246 branch January 10, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants