Skip to content

v3.1: tpu-client-next: set connection retry value to 1 for first retry (backport of #9581)#9616

Merged
KirillLykov merged 1 commit intov3.1from
mergify/bp/v3.1/pr-9581
Dec 18, 2025
Merged

v3.1: tpu-client-next: set connection retry value to 1 for first retry (backport of #9581)#9616
KirillLykov merged 1 commit intov3.1from
mergify/bp/v3.1/pr-9581

Conversation

@mergify
Copy link

@mergify mergify bot commented Dec 17, 2025

Problem

Fix bug with incorrect retry counter used for re-establishing connections.
This value is used like the follows:

                   ConnectionState::Retry(num_reconnects) => {
                        if *num_reconnects > self.max_reconnect_attempts {
                            error!(
                                "Failed to establish connection to {}: reached max reconnect \
                                 attempts",
                                self.peer
                            );
                            self.connection = ConnectionState::Closing;
                            continue;
                        }
                        sleep(RETRY_SLEEP_INTERVAL).await;
                        self.reconnect(*num_reconnects).await;
                    }

So if max_reconnect_attempts == 0 we get 0 > 0 and try reconnecting, which is not what expected.

Summary of Changes


This is an automatic backport of pull request #9581 done by [Mergify](https://mergify.com).

set connection retry value to 1 for first retry

(cherry picked from commit 2dc0fac)
@mergify mergify bot requested a review from a team as a code owner December 17, 2025 15:18
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.2%. Comparing base (7abb6df) to head (6854f72).

Additional details and impacted files
@@            Coverage Diff            @@
##             v3.1    #9616     +/-   ##
=========================================
- Coverage    83.2%    83.2%   -0.1%     
=========================================
  Files         865      865             
  Lines      376059   376059             
=========================================
- Hits       313072   313071      -1     
- Misses      62987    62988      +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KirillLykov KirillLykov merged commit 67963d6 into v3.1 Dec 18, 2025
44 checks passed
@KirillLykov KirillLykov deleted the mergify/bp/v3.1/pr-9581 branch December 18, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants