fix: genesis: feature-gated vote state by buffalojoec · Pull Request #9467 · anza-xyz/agave

buffalojoec · 2025-12-09T08:36:08Z

Problem

As described in #9377, development clusters who deactivate the vote state v4 feature are stalling since the genesis config will create vote state v4 accounts anyway.

Summary of Changes

Changes the no-features variant (create_genesis_config_with_leader_ex_no_features) to first check the provided initial_accounts for the vote account, and default to vote state V3 if not provided. For the variant with all features enabled (create_genesis_config_with_leader_ex), use vote state V4.

Also removes the BLS pubkey arg from the no-features variant since it's unused.

Fixes #9377

mergify · 2025-12-09T08:36:42Z

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

runtime/src/genesis_utils.rs

test-validator/src/lib.rs

codecov-commenter · 2025-12-09T13:02:39Z

Codecov Report

❌ Patch coverage is 41.42857% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.5%. Comparing base (ec8ba13) to head (f080d70).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #9467       +/-   ##
===========================================
- Coverage    82.7%    67.5%    -15.2%     
===========================================
  Files         901      803       -98     
  Lines      324743   225552    -99191     
===========================================
- Hits       268704   152471   -116233     
- Misses      56039    73081    +17042

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

runtime/src/genesis_utils.rs

mergify · 2025-12-11T01:57:30Z

If this PR represents a change to the public RPC API:

Make sure it includes a complementary update to rpc-client/ (example)
Open a follow-up PR to update the JavaScript client @solana/kit (example)

Thank you for keeping the RPC clients in sync with the server API @buffalojoec.

AshwinSekar

LGTM, cc @t-nelson for approval since I believe we want to backport this to 3.1

mergify · 2025-12-12T07:26:16Z

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

t-nelson · 2025-12-16T17:35:41Z

can we get the feature set plumbing changes factored out of the first commit and i think the last two commits of ag slop dropped?

buffalojoec · 2025-12-17T04:49:31Z

can we get the feature set plumbing changes factored out of the first commit and i think the last two commits of ag slop dropped?

Ok so you basically want just a simpler fix here for the sake of backport? I'll probably just rewrite the commits.

buffalojoec · 2025-12-17T06:20:35Z

can we get the feature set plumbing changes factored out of the first commit and i think the last two commits of ag slop dropped?

Ok so you basically want just a simpler fix here for the sake of backport? I'll probably just rewrite the commits.

@t-nelson I think this new commit will backport better, and avoids any unnecessary refactoring.

t-nelson · 2025-12-21T15:29:35Z

runtime/src/genesis_utils.rs

-    initial_accounts: Vec<(Pubkey, AccountSharedData)>,
+    mut initial_accounts: Vec<(Pubkey, AccountSharedData)>,
 ) -> GenesisConfig {
+    if cluster_type == ClusterType::Development {


this isn't really the dependency tho. we should

factor feature gate activation as early as possible

plumb the feature set to where it needs to be

select the correct account format based on the feature gate status

This is precisely what my first PR was doing - maybe I misunderstood your request, but you said you wanted feature set plumbing factored out of the commit?

yeah I just wanted it in separate commits so it was actually reviewable

Ok I pushed up commits as you requested.

t-nelson · 2025-12-21T15:29:52Z

programs/vote/src/vote_state/mod.rs


-#[cfg(test)]
-pub fn create_account_with_authorized(
+pub fn create_v3_account_with_authorized(


this is what modules are for

t-nelson

much more reviewable, thanks!

t-nelson · 2026-01-08T17:31:43Z

runtime/src/genesis_utils.rs

+            )
+        } else {
+            // Vote state v4 feature inactive. Create a v3 account.
+            if bls_pubkey_compressed.is_some() {


probably for a followup, but this can probably be enforced by clap. if not, it should at least be moved up to where cli args are initially resolved

* factor feature gate activation as early as possible * plumb the feature set to where it needs to be * select the proper account format based on the feature gate status * cleanup * apply similar patch to solana-genesis (cherry picked from commit 50c813a) # Conflicts: # genesis/src/main.rs # test-validator/src/lib.rs

* factor feature gate activation as early as possible * plumb the feature set to where it needs to be * select the proper account format based on the feature gate status * cleanup * apply similar patch to solana-genesis

fix: genesis: feature-gated vote state (#9467) * factor feature gate activation as early as possible * plumb the feature set to where it needs to be * select the proper account format based on the feature gate status * cleanup * apply similar patch to solana-genesis Co-authored-by: Joe C <joe.caulfield@anza.xyz>

buffalojoec commented Dec 9, 2025

View reviewed changes

runtime/src/genesis_utils.rs Show resolved Hide resolved

buffalojoec commented Dec 9, 2025

View reviewed changes

runtime/src/genesis_utils.rs Outdated Show resolved Hide resolved

buffalojoec commented Dec 9, 2025

View reviewed changes

test-validator/src/lib.rs Outdated Show resolved Hide resolved

buffalojoec marked this pull request as ready for review December 9, 2025 23:38

buffalojoec requested a review from AshwinSekar December 9, 2025 23:38

AshwinSekar reviewed Dec 10, 2025

View reviewed changes

runtime/src/genesis_utils.rs Show resolved Hide resolved

AshwinSekar reviewed Dec 11, 2025

View reviewed changes

AshwinSekar added the v3.1 Backport to v3.1 branch label Dec 12, 2025

buffalojoec force-pushed the genesis-feature-gated-vote-state branch from 63c88b8 to 3899768 Compare December 17, 2025 06:20

buffalojoec force-pushed the genesis-feature-gated-vote-state branch from 3899768 to c16465b Compare December 17, 2025 10:10

t-nelson reviewed Dec 21, 2025

View reviewed changes

buffalojoec force-pushed the genesis-feature-gated-vote-state branch from c16465b to f6eacf8 Compare December 23, 2025 17:35

buffalojoec added 5 commits January 7, 2026 15:26

factor feature gate activation as early as possible

b032b10

plumb the feature set to where it needs to be

6a7d6a9

select the proper account format based on the feature gate status

4af730d

cleanup

4fa6105

apply similar patch to solana-genesis

f080d70

buffalojoec force-pushed the genesis-feature-gated-vote-state branch from f6eacf8 to f080d70 Compare January 7, 2026 15:29

buffalojoec requested a review from t-nelson January 7, 2026 23:31

t-nelson approved these changes Jan 8, 2026

View reviewed changes

buffalojoec added this pull request to the merge queue Jan 9, 2026

Merged via the queue into anza-xyz:master with commit 50c813a Jan 9, 2026
58 checks passed

buffalojoec deleted the genesis-feature-gated-vote-state branch January 9, 2026 00:37

mergify bot mentioned this pull request Jan 9, 2026

v3.1: fix: genesis: feature-gated vote state (backport of #9467) #9879

Merged

buffalojoec mentioned this pull request Jan 16, 2026

ledger-tool: use feature set to choose vote state #10078

Merged

Conversation

buffalojoec commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Summary of Changes

Uh oh!

mergify bot commented Dec 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

mergify bot commented Dec 11, 2025

Uh oh!

AshwinSekar left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Dec 12, 2025

Uh oh!

t-nelson commented Dec 16, 2025

Uh oh!

buffalojoec commented Dec 17, 2025

Uh oh!

buffalojoec commented Dec 17, 2025

Uh oh!

t-nelson Dec 21, 2025

Choose a reason for hiding this comment

Uh oh!

buffalojoec Dec 21, 2025

Choose a reason for hiding this comment

Uh oh!

t-nelson Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

buffalojoec Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

t-nelson Dec 21, 2025

Choose a reason for hiding this comment

Uh oh!

t-nelson left a comment

Choose a reason for hiding this comment

Uh oh!

t-nelson Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

buffalojoec commented Dec 9, 2025 •

edited

Loading

codecov-commenter commented Dec 9, 2025 •

edited

Loading