SIMD-0417: Assign Ed25519 precompile to native loader #9311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot already assigned
buffalojoec
reviewed
Nov 27, 2025
| ), | ||
| ( | ||
| assign_ed25519_precompile_to_native_loader::id(), | ||
| "Assign Ed25519 Precompile to native loader", |
There was a problem hiding this comment.
I was going to suggest prefixing this message with "Testnet:", but that might actually be more confusing. Leaving this comment here for anyone who might want the prefix.
Comment on lines
+5375
to
+5380
| let new_account = AccountSharedData::from(Account { | ||
| owner: native_loader::ID, | ||
| executable: true, | ||
| data: b"ed25519_program".to_vec(), | ||
| ..Account::from(account) | ||
| }); |
There was a problem hiding this comment.
You can just use the WritableAccount trait to mutate the retrieved account directly, then store it back.
Author
|
closing as the testnet validators have finally figured out how to use the ledger tool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A very old issue solana-labs#23219 of the Ed25519 program belonging to System Program rather than the Native Loader program has once again resurfaced. At the time, it was not resolved in a way that results in a consistent program owner across all clusters. As a result, the recent activation of SIMD-0186 has broken the Ed25519 precompile on the testnet cluster due to this branch of code now correctly enforcing the behavior we should have solved for:
agave/svm/src/account_loader.rs
Lines 607 to 610 in 89ead14
Summary of Changes
This PR implements solana-foundation/solana-improvement-documents#417, introducing a feature gate that, when activated on testnet, updates the owner of the Ed25519 program to the Native Loader program and explicitly flags it as executable. All other account fields remain unchanged. No functionality changes occur on mainnet or devnet.
Fixes solana-labs#23219