validator: Deprecate --dev-halt-at-slot

CHANGELOG.md

@@ -48,6 +48,7 @@ deprecated, signaling their inclusion in the Agave Unstable API. Enable the
 `agave-unstable-api` crate feature to acknowledge use of an interface that may break
 without warning. From v4.0.0 onward, symbols in these crates will be unavailable without
 `agave-unstable-api` enabled.
+* The `--dev-halt-at-slot` flag is now deprecated.
 
 #### Changes
 * The accounts index is now kept entirely in memory by default.

validator/src/cli.rs

@@ -136,6 +136,16 @@ fn deprecated_arguments() -> Vec<DeprecatedArg> {
             .help("Use CUDA"),
         usage_warning: "CUDA support will be dropped"
     );
+    add_arg!(
+        // deprecated in v3.1.3
+        Arg::with_name("dev_halt_at_slot")
+            .long("dev-halt-at-slot")
+            .value_name("SLOT")
+            .validator(is_slot)
+            .takes_value(true)
+            .help("Halt the validator when it reaches the given slot"),
+        usage_warning: "--dev-halt-at-slot will be removed in the future"
+    );
     add_arg!(
         // deprecated in v3.1.0
         Arg::with_name("tpu_coalesce_ms")

validator/src/commands/run/args.rs

@@ -240,14 +240,6 @@ pub fn add_args<'a>(app: App<'a, 'a>, default_args: &'a DefaultArgs) -> App<'a,
                  the cluster. The --no-voting flag is implicit when this flag is enabled",
             ),
     )
-    .arg(
-        Arg::with_name("dev_halt_at_slot")
-            .long("dev-halt-at-slot")
-            .value_name("SLOT")
-            .validator(is_slot)
-            .takes_value(true)
-            .help("Halt the validator when it reaches the given slot"),
-    )
     .arg(
         Arg::with_name("rpc_port")
             .long("rpc-port")