-
Notifications
You must be signed in to change notification settings - Fork 845
replace serde_derive dep with derive feature on serde #8421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
For your information, the |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8421 +/- ##
=======================================
Coverage 83.2% 83.2%
=======================================
Files 846 846
Lines 369242 369246 +4
=======================================
+ Hits 307372 307448 +76
+ Misses 61870 61798 -72 🚀 New features to boost your workflow:
|
alexpyattaev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the gossip, votor, net-utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no apparent degradation in build time on my workstation
Feature unification means there should be not be any hit building the workspace if I'm not mistaken. Rather, I believe any build time degradation would show up in a crate that is using serde but not the serde_derive.
Either way, LGTM
Another win from this is these derive macros were the source of lots of false positives with tools like cargo machete IIRC; might have more reasonable output with this in
nah read the original issue. bug was that the original |
Problem
according to serde-rs/serde#2608, the issue below has been resolved upstream
agave/Cargo.toml
Lines 358 to 361 in f1fb3d2
Summary of Changes
replace
serde_derivecrate dep with thederivefeature on theserdecrateno apparent degradation in build time on my workstation