clippy: allow all clippy for mod google in storage-bigtable#2543
Merged
yihau merged 1 commit intoanza-xyz:masterfrom Aug 13, 2024
Merged
clippy: allow all clippy for mod google in storage-bigtable#2543yihau merged 1 commit intoanza-xyz:masterfrom
yihau merged 1 commit intoanza-xyz:masterfrom
Conversation
yihau
changed the title
steviez
approved these changes
Aug 12, 2024
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
I think I'm good with ignoring everything from clippy if the intent is to use the auto-generated code as-is. We could potentially enumerate out the individual lints we're ignoring, but again, if we don't intend to do anything about them, then I'm not sure I see much value in the extra work.
Giving this a ship it but wouldn't mind hearing @CriesofCarrots thoughts too
CriesofCarrots
approved these changes
Aug 12, 2024
CriesofCarrots
left a comment
CriesofCarrots
left a comment
There was a problem hiding this comment.
Love it. I don't think it should be incumbent on us to track which lints tonic is up to date with.
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
…#2543) clippy: allow all for mod google in storage-bigtable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(part of #2487)
Problem
the files in
storage-bigtable/proto/*.rsare generated by https://github.com/anza-xyz/agave/blob/master/storage-bigtable/build-proto/build.sh (#2497 (comment))we should ignore clippy checks for those files otherwise we will need to make the same modifications during the next round generation if the upstream doesn't fix the clippy issue.
Summary of Changes
allow all for mod google