Conversation
brooksprumo
requested changes
Aug 8, 2024
Co-authored-by: Brooks <[email protected]>
Co-authored-by: Brooks <[email protected]>
Member
Author
|
thank you! just committed those 2 changes 🫡 |
brooksprumo
requested changes
Aug 9, 2024
accounts-db/src/account_storage.rs
Outdated
Comment on lines
47
to
48
| /// Operations like shrinking or write cache flushing may have updated the index between when the caller read the index and called this function to | ||
| /// load from the append vec specified in the index. |
There was a problem hiding this comment.
I think the extra leading spaces can be removed.
Member
Author
There was a problem hiding this comment.
thank you for catching this one! fixed: 1b6f399
| //! 2. multiple 'slots' squashed into a single older (ie. ancient) slot for convenience and performance | ||
| //! Otherwise, an ancient append vec is the same as any other append vec | ||
| //! | ||
| //! Otherwise, an ancient append vec is the same as any other append vec |
Member
Author
There was a problem hiding this comment.
same here! 828cad4 thank you very much! I almost commit a weird docs format into master 🙈
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
* docs fix: accounts-db * Update accounts-db/src/account_storage.rs Co-authored-by: Brooks <[email protected]> * Update accounts-db/src/ancient_append_vecs.rs Co-authored-by: Brooks <[email protected]> * remove redundant indent * remove redundant indent --------- Co-authored-by: Brooks <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(part of #2487)
Problem
docs take a stricter approach to indentation rules…
Summary of Changes
fix it