Skip to content

v3.1: consensus: axe the intermediate accumulation pathway for OC (backport of #10594)#10697

Merged
AshwinSekar merged 2 commits intov3.1from
mergify/bp/v3.1/pr-10594
Feb 19, 2026
Merged

v3.1: consensus: axe the intermediate accumulation pathway for OC (backport of #10594)#10697
AshwinSekar merged 2 commits intov3.1from
mergify/bp/v3.1/pr-10594

Conversation

@mergify
Copy link

@mergify mergify bot commented Feb 19, 2026

Problem

This optimization doesn't actually get us anything and is complex to reason about
Screenshot 2026-02-13 at 11 01 32 PM

Summary of Changes

Remove it and bank hash cache to ibrl


This is an automatic backport of pull request #10594 done by Mergify.

* consensus: axe the intermediate accumulation pathway for OC

* pr feedback: fold continue into filter

(cherry picked from commit 207fb1d)

# Conflicts:
#	core/src/cluster_info_vote_listener.rs
#	runtime/src/bank_forks.rs
#	runtime/src/bank_hash_cache.rs
@mergify mergify bot added the conflicts label Feb 19, 2026
@mergify mergify bot requested a review from a team as a code owner February 19, 2026 16:00
@mergify
Copy link
Author

mergify bot commented Feb 19, 2026

Cherry-pick of 207fb1d has failed:

On branch mergify/bp/v3.1/pr-10594
Your branch is up to date with 'origin/v3.1'.

You are currently cherry-picking commit 207fb1d00.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   runtime/src/lib.rs

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   core/src/cluster_info_vote_listener.rs
	both modified:   runtime/src/bank_forks.rs
	deleted by them: runtime/src/bank_hash_cache.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bp ack

Copy link

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like 100% of conflicts are just tied to migration status not existing. Conflict resolution looks good to me

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.2%. Comparing base (ba0d1f8) to head (faf26c3).

Additional details and impacted files
@@            Coverage Diff            @@
##             v3.1   #10697     +/-   ##
=========================================
- Coverage    83.2%    83.2%   -0.1%     
=========================================
  Files         865      864      -1     
  Lines      376843   376733    -110     
=========================================
- Hits       313801   313705     -96     
+ Misses      63042    63028     -14     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AshwinSekar AshwinSekar merged commit 765ee54 into v3.1 Feb 19, 2026
44 checks passed
@AshwinSekar AshwinSekar deleted the mergify/bp/v3.1/pr-10594 branch February 19, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants