Skip to content

v3.1: Sigverify - receive loop up to packet limit (backport of #10428)#10521

Merged
apfitzge merged 2 commits intov3.1from
mergify/bp/v3.1/pr-10428
Feb 18, 2026
Merged

v3.1: Sigverify - receive loop up to packet limit (backport of #10428)#10521
apfitzge merged 2 commits intov3.1from
mergify/bp/v3.1/pr-10428

Conversation

@mergify
Copy link

@mergify mergify bot commented Feb 10, 2026

Problem

  • try_recv loop is going too long

Summary of Changes

  • stop the try_recv loop after receiving a soft cap on packets
    • soft cap because we break once exceeded

Fixes #


This is an automatic backport of pull request #10428 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner February 10, 2026 18:35
@mergify mergify bot added the conflicts label Feb 10, 2026
@mergify
Copy link
Author

mergify bot commented Feb 10, 2026

Cherry-pick of 8c86b1c has failed:

On branch mergify/bp/v3.1/pr-10428
Your branch is up to date with 'origin/v3.1'.

You are currently cherry-picking commit 8c86b1c64.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   core/src/sigverify_stage.rs
	modified:   streamer/src/streamer.rs

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   core/src/bls_sigverifier.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@t-nelson
Copy link

@Mergifyio rebase

@mergify
Copy link
Author

mergify bot commented Feb 11, 2026

rebase

☑️ Nothing to do, the required conditions are not met

Details
  • any of:
    • #commits-behind > 0 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • -conflict [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]

@t-nelson
Copy link

derp. need a fix for the audit failure

@t-nelson
Copy link

@Mergifyio rebase

(cherry picked from commit 8c86b1c)

# Conflicts:
#	core/src/bls_sigverifier.rs
@mergify
Copy link
Author

mergify bot commented Feb 18, 2026

rebase

✅ Branch has been successfully rebased

@t-nelson t-nelson force-pushed the mergify/bp/v3.1/pr-10428 branch from 5ec7e80 to 89c0583 Compare February 18, 2026 17:14
Copy link

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apfitzge who's a good sme here?

@apfitzge
Copy link

@apfitzge who's a good sme here?

@alessandrod

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.2%. Comparing base (01a77c7) to head (89c0583).

Additional details and impacted files
@@            Coverage Diff            @@
##             v3.1   #10521     +/-   ##
=========================================
- Coverage    83.2%    83.2%   -0.1%     
=========================================
  Files         865      865             
  Lines      376601   376605      +4     
=========================================
- Hits       313609   313556     -53     
- Misses      62992    63049     +57     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apfitzge apfitzge requested a review from alessandrod February 18, 2026 17:58
@apfitzge apfitzge merged commit eed17d6 into v3.1 Feb 18, 2026
44 checks passed
@apfitzge apfitzge deleted the mergify/bp/v3.1/pr-10428 branch February 18, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants