-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: Enhance transition api #4848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @q32757468, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a comprehensive enhancement to the animation system, providing developers with more granular control over how elements transition within the graph. It expands the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly enhances the animation API by incorporating features from the Web Animations API, such as iterations, direction, and fill options. This enables more complex and repeatable animations, including infinite loops. The changes also introduce support for declarative animations on cells via a transition property and a new view:render event, which is useful for DOM-based animations. The new examples effectively demonstrate these powerful new features. The core animation logic has been well-refactored to accommodate these enhancements. I have a couple of suggestions to improve code maintainability in src/model/cell.ts.
eb6e10c to
5826fd9
Compare
5826fd9 to
86294d0
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4848 +/- ##
==========================================
- Coverage 81.94% 81.94% -0.01%
==========================================
Files 327 327
Lines 37972 38019 +47
Branches 7632 7637 +5
==========================================
+ Hits 31116 31153 +37
- Misses 6832 6841 +9
- Partials 24 25 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
官方文档需要补充一下吗? |
@GaoFuhong 上周来不及加文档和补充示例了,准备先把API改动提上来看看,然后没问题就加加文档和示例~ |
| let progress = calculateDirectionProgress(timeFraction, iterationIndex) | ||
|
|
||
| if (iterationIndex < localOptions.iterations) { | ||
| this.ids[key] = requestAnimationFrame(iterate) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.ids 存在内存泄漏风险,需要 delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我看看处理一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看了一下,这里的ids应该是不存在风险,clean 本身会 delete 掉

不过我看这个issue提到会有相关问题,等后面我尝试复现修复一下
#4357
f945ce8 to
f107566
Compare
Description
不同动画形式的效果:

写了example,也可以拉下来看各种形式的动画效果
Motivation and Context
Types of changes
Self Check before Merge