Add IQ2 tensor types #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were added in ggml-org/llama.cpp#4773 It's annoying that I8 used to be 16 and it's now 18. I16 and I32 also changed.
Owner
|
Hello @jbochi sorry I noticed this only know. Can I still merge it? Thanks. |
Contributor
Author
|
No worries! I think this is not needed anymore. it was implemented in a
different PR.
…On Thu, Jan 9, 2025, 10:12 AM Salvatore Sanfilippo ***@***.***> wrote:
Hello @jbochi <https://github.com/jbochi> sorry I noticed this only know.
Can I still merge it? Thanks.
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACHO2FAQKALTY7AY6OVEGT2J2GWRAVCNFSM6AAAAABU4L6BOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBQGUZDONBSGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Owner
|
Thanks! I'll check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were added in ggml-org/llama.cpp#4773
It's annoying that I8 used to be 16 and it's now 18. I16 and I32 also changed.
Dequantization code is very cryptic. I would love to see your take :)