fix(docx): make XML validation and console output Windows-safe#871
Open
voidborne-d wants to merge 1 commit intoanthropics:mainfrom
Open
fix(docx): make XML validation and console output Windows-safe#871voidborne-d wants to merge 1 commit intoanthropics:mainfrom
voidborne-d wants to merge 1 commit intoanthropics:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
encoding="utf-8"->Why
Fixes #712.
The docx office scripts currently rely on the platform default text encoding in one XML validation path, which breaks on Windows when the default codec is cp1252. They also print
→in two validation/repair messages, which can raiseUnicodeEncodeErroron cp1252 terminals.This keeps the XML parsing path deterministic across platforms and makes the console output safe on default Windows terminals without requiring
PYTHONIOENCODING=utf-8.Testing
python3 -m unittest tests.test_docx_windows_encoding -v