Merged
Conversation
maheshmurag
approved these changes
Oct 16, 2025
seanphan
pushed a commit
to PixelML/skills
that referenced
this pull request
Oct 20, 2025
…-detection Implements robust auth strategy based on MCP Server TypeScript implementation: Auth Architecture Changes: - Hybrid auth: persistent browser profile (user_data_dir) + manual cookie injection - Fixes Playwright bug #36139: Session cookies now persist correctly - Real Chrome via channel="chrome" instead of Chromium (cross-platform reliability) - Remove automation detection: ignore_default_args=["--enable-automation"] - Manual cookie injection from state.json for session cookie persistence Technical Details: - Python's launch_persistent_context doesn't support storage_state parameter (unlike TypeScript) - Workaround: Launch with user_data_dir, then manually inject cookies via context.add_cookies() - Browser profile stores: fingerprint + persistent cookies + cache - state.json stores: ALL cookies including session cookies (expires=-1) - This ensures both consistent fingerprinting AND reliable session cookie persistence Files Changed: - scripts/ask_question.py: Add hybrid auth + ignore_default_args - scripts/auth_manager.py: Update setup_auth() and validate_auth() with new approach - scripts/setup_environment.py: Install Chrome instead of Chromium - requirements.txt: Add Chrome installation note - README.md: Add Chrome installation section with rationale - AUTHENTICATION.md: NEW - Complete auth architecture documentation Why This Fixes Issue anthropics#2: - Session cookies (without Expires) were lost on restart (Playwright bug) - Chromium had cross-platform reliability issues - Manual cookie injection ensures session cookies persist - Real Chrome ensures consistent behavior across systems References: - Playwright Issue #36139: Session cookies not persisting - Playwright Issue #14949: storage_state with persistent context - Based on: notebooklm-mcp TypeScript implementation
Okeysir198
referenced
this pull request
in Okeysir198/P20251122-claude-skills
Nov 21, 2025
⚠️ PRODUCTION BLOCKER IDENTIFIED⚠️ After comprehensive execution flow analysis, discovered critical deadlock in streaming implementation that will cause hangs in production. Critical Bug #1: DEADLOCK in end_input() Flow --------------------------------------------- - When end_input() is called, client stops sending audio - Client does NOT notify server that streaming is complete - Server waits for more audio indefinitely - Client waits for final transcriptions indefinitely - MUTUAL DEADLOCK - both sides waiting forever Current Flow (BROKEN): 1. User calls stream.end_input() 2. _send_loop() receives None sentinel and exits 3. But _send_loop() does NOT send end-of-stream message to server 4. Server continues waiting for audio 5. _recv_loop() waits for server messages 6. User waits for async iteration to complete 7. DEADLOCK Impact: - Any code using end_input() will hang indefinitely - Tests only pass because they use timeouts + explicit aclose() - Will cause production outages Reproduction: ```python stream = stt.stream() # ... push frames ... await stream.end_input() async for event in stream: # HANGS FOREVER print(event) ``` Additional Bugs Found: --------------------- - Bug #2: Multiple None sentinels queued (end_input + aclose) - Bug #3: Frames accepted after end_input() (silent data loss) - Bug #5: Unnecessary None queued in aclose() before cancellation Files Added: - CRITICAL_BUGS.md - Detailed execution trace and bug analysis - FIXES_REQUIRED.md - Complete fix implementation with code Current Status: ❌ NOT PRODUCTION READY Next Steps: Implement fixes in FIXES_REQUIRED.md (~3 hours) Tests pass currently only due to timeout workarounds masking the deadlock.
xjrmh
pushed a commit
to xjrmh/skills
that referenced
this pull request
Mar 3, 2026
paulgnz
added a commit
to XPRNetwork/skills
that referenced
this pull request
Mar 18, 2026
Updates from merged PRs: - Fix LOAN protocol docs: lending.loan contract, shares.loan L-tokens, mint/redeem actions (anthropics#4) - Fix staking actions: eosio::stakexpr not eosio.proton::stake (anthropics#6) - Document all-numeric account name RPC bug with workarounds (anthropics#5) - Add proton.swaps AMM pool documentation - Add critical DEX deposit memo warning - Replace stale proton.greymass.com endpoints with active ones - Clarify mobile wallet critical settings (anthropics#2) - Add verified P2P peers (#1) Co-Authored-By: charliebot87 <charliebot87@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.