-
Notifications
You must be signed in to change notification settings - Fork 133
Add _meta to manifest schema and tests #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _meta to manifest schema and tests #124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving spec changes 👍
|
adding @domdomegg ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My overall opinion (am not the owner of mcpb stuff :), just 2 cents):
- I like the idea of
client_extensions. Giving the community an extension point that can be used flexibly seems like a good escape hatch + a way to learn how people are using things and adopt the good stuff. To align with the main MCP spec I might call this_meta, which can still have whatever you want in it basically. There's a bit of a convention of using reverse DNS names, e.g.com.microsoft.windowsmaybe, but it is freeform. - I'm not super convinced by
static_responsesyet. My guess is the performance benefit is pretty minimal, and it might duplicate a lot of the stuff already intoolsorprompts. For richer discovery it feels like it might live better in the registry (we've had some discussions there - see modelcontextprotocol/registry#79 and modelcontextprotocol/registry#82)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…sions with _meta for improved organization
50a8c5a to
443d849
Compare
…onses_and_extensions Add _meta to manifest schema and tests
Summary
Adds a
_metafield to the manifest for platform/client–specific metadata objects (e.g. Windowspackage_family_name, macOS bundle identifiers, custom client integration info).Schema, tests, and documentation updated accordingly.