fix(hookify): search both project and home directories for rule files#29095
Open
4RH1T3CT0R7 wants to merge 1 commit intoanthropics:mainfrom
Open
fix(hookify): search both project and home directories for rule files#290954RH1T3CT0R7 wants to merge 1 commit intoanthropics:mainfrom
4RH1T3CT0R7 wants to merge 1 commit intoanthropics:mainfrom
Conversation
glob.glob with a relative path only searched the current working directory. Users with global rules in ~/.claude/hookify.*.local.md would have them silently ignored when cwd was a project directory (which is always the case in normal Claude Code usage). Add a second search for ~/.claude/ and deduplicate by absolute path to handle the edge case where cwd is the home directory. Fixes anthropics#20749
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
load_rules()usesglob.glob('.claude/hookify.*.local.md')— a relative path from cwd~/.claude/are silently ignored~/.claude/hookify.*.local.mdsee them never loadedChanges
plugins/hookify/core/config_loader.pylines 209-211: search both project-level (.claude/) and home-level (~/.claude/) directoriesos.path.abspath()to handle the edge case where cwd is the home directoryTest plan
~/.claude/hookify.test-global.local.mdwith a valid rule~/.claude/and<project>/.claude/— verify loaded only onceFixes #20749