fix: portable shebang should use env for bash#13307
Open
longregen wants to merge 1 commit intoanthropics:mainfrom
Open
fix: portable shebang should use env for bash#13307longregen wants to merge 1 commit intoanthropics:mainfrom
longregen wants to merge 1 commit intoanthropics:mainfrom
Conversation
Both work, but `#!/usr/bin/env bash` is generally preferred for portability. It works on most Linux systems where bash lives at /bin/bash, but fails on systems where bash is installed elsewhere (e.g., /usr/local/bin/bash on some BSDs, NixOS, or macOS with Homebrew-preferred bash)
Author
|
In my nixos environment, this generates the following error for ralph-wiggum after each message: |
Author
|
Surfacing this again? It's a fairly trivial change, would be great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both work, but
#!/usr/bin/env bashis generally preferred for portability.#!/bin/bashworks on most Linux systems where bash lives at /bin/bash, but fails on systems where bash is installed elsewhere. For example, some BSDs install it on /usr/local/bin/bash and NixOS installs it on /run/current-system/bin/bash.Quote from Chris's Wiki, a well known Unix and Sysadmin blogger:
I'd argue that because
claudewill be used in really varied environments, the default should be whateverbashis in the PATH, not hard-code to /bin/bash. Particularly, for users that preferbrew-provided bash,/bin/bashwill point to MacOS's bash instead of their preferred version.