fix: prevent duplicate security review comments on PRs#78
Open
0x48core wants to merge 2 commits intoanthropics:mainfrom
Open
fix: prevent duplicate security review comments on PRs#780x48core wants to merge 2 commits intoanthropics:mainfrom
0x48core wants to merge 2 commits intoanthropics:mainfrom
Conversation
Author
|
@ddworken @GrahamCampbell @Eduard-Voiculescu could you review my PR, thank you so much! |
platformengineer281
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues caused duplicate security comments to appear on PRs:
No concurrency control — parallel workflow runs on the same PR would
both see zero existing comments and post the same findings. Added a
concurrency group keyed by PR number with cancel-in-progress.
Missing pagination — the existing comments check used the default
page size (30), so security comments beyond page 1 were invisible.
Replaced with a paginated fetch helper (ghApiAll) that retrieves all
comments.
Also replaced the all-or-nothing deduplication with per-finding
fingerprinting (file:line:message) so genuinely new findings on later
commits still get posted while true duplicates are skipped.