Skip to content

Fix/trigger validation redundant conditional #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/trigger validation redundant conditional #392

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bef5cb2
refactor: eliminate redundant conditional in trigger check
uc4w6c Aug 4, 2025
a1b6d4d
refactor: remove unused function
uc4w6c Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions src/github/validation/trigger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#!/usr/bin/env bun

import * as core from "@actions/core";
import {
isIssuesEvent,
isIssuesAssignedEvent,
Expand Down Expand Up @@ -119,9 +118,7 @@ export function checkContainsTrigger(context: ParsedGitHubContext): boolean {
isIssueCommentEvent(context) ||
isPullRequestReviewCommentEvent(context)
) {
const commentBody = isIssueCommentEvent(context)
? context.payload.comment.body
: context.payload.comment.body;
const commentBody = context.payload.comment.body;
// Check for exact match with word boundaries or punctuation
const regex = new RegExp(
`(^|\\s)${escapeRegExp(triggerPhrase)}([\\s.,!?;:]|$)`,
Expand All @@ -140,9 +137,3 @@ export function checkContainsTrigger(context: ParsedGitHubContext): boolean {
export function escapeRegExp(string: string) {
return string.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
}

export async function checkTriggerAction(context: ParsedGitHubContext) {
Copy link
Contributor Author

@uc4w6c uc4w6c Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer called after this change.

const containsTrigger = checkContainsTrigger(context);
core.setOutput("contains_trigger", containsTrigger.toString());
return containsTrigger;
}