don't strip path from filename in multipart #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packyg
reviewed
Nov 18, 2025
Contributor
packyg
left a comment
packyg
left a comment
There was a problem hiding this comment.
I think this is undesired when using toFile for the files API as that endpoint expects the filename to not be a path
I guess you could say it's caller's responsibility to name the file correctly, but I'm somewhat concerned about breaking existing use cases
Author
|
Yeah that is totally reasonable. It is a little tricky to do this in a way that's intuitive but also doesn't break existing code. Like we could omit stripping the file name for the skills endpoint but leave it in for other endpoints, though that may be confusing to some 🤷♀️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.