Skip to content

Conversation

@xiaohuoni
Copy link
Member

@xiaohuoni xiaohuoni commented Mar 9, 2019

  • config/*
  • src/models/*
  • src/pages/*
  • src/services/*
  • src/utils/*
  • src/layouts/*
  • remove e2e/*
  • mock/*

src/components

  • src/components/GlobalHeader
  • src/components/HeaderDropdown
  • src/components/HeaderSearch
  • src/components/IconFont
  • src/components/PageLoading
  • src/components/SelectLang
  • src/components/SettingDrawer
  • src/components/SiderMenu
  • src/components/TopNavHeader
  • src/locales/*
  • src/app.js
  • src/defaultSettings.js
  • src/global.js
  • remove test

The following documents are not within the scope of this PR revision(😊)
functions/*
src/service-worker.js
.eslintrc.js
jest.config.js

@xiaohuoni xiaohuoni requested a review from yutingzhao1991 March 9, 2019 03:29
@netlify
Copy link

netlify bot commented Mar 9, 2019

Deploy preview for ant-design-pro ready!

Built with commit ee41e3b

https://deploy-preview-3702--ant-design-pro.netlify.com

@xiaohuoni xiaohuoni changed the title merge v3 to v4 v4 transform typescript Mar 9, 2019
@xiaohuoni xiaohuoni changed the title v4 transform typescript [v4] transform typescript Mar 9, 2019
@yutingzhao1991 yutingzhao1991 mentioned this pull request Mar 9, 2019
12 tasks
@yutingzhao1991
Copy link
Contributor

棒!

@xiaohuoni
Copy link
Member Author

src/components/GlobalHeader/RightContent.tsx
会有两个类型定义错误,
因为 NoticeIcon 组件类型定义错误,已在ant-design-pro主分支中修复。
import { NoticeIcon } from 'ant-design-pro';
代码里面标记了 todo:但是估计CI过不了。

@xiaohuoni
Copy link
Member Author

xiaohuoni commented Mar 9, 2019

临时删除了e2e和test,文件清单如下,后续统一补充。

e2e/baseLayout.e2e.js
e2e/home.e2e.js
e2e/topMenu.e2e.js
e2e/userLayout.e2e.js
src/components/SiderMenu/SiderMenu.test.js
src/components/_utils/pathTools.test.js
src/utils/utils.test.js

src/utils/authority.test.js

@xiaohuoni
Copy link
Member Author

完成!

@chenshuai2144
Copy link
Collaborator

顺便把 PureComponent 改成 Component 吧,pro里面暂时没有用的必要

@yesmeck
Copy link
Member

yesmeck commented Mar 9, 2019

#3706

@yutingzhao1991
Copy link
Contributor

这个基础的 PR 可以先合了,后面可以 PR 频繁一点,每个 PR 小一点,节奏搞起来!~

@xiaohuoni xiaohuoni merged commit 1abac6a into v4 Mar 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the v3-merge-to-v4 branch March 11, 2019 12:29
@xiaohuoni
Copy link
Member Author

哈哈哈,OK!知道了!这个规则还没定,可以考虑等antd的规则沉淀。ant-design/ant-design#15236

@xiaohuoni
Copy link
Member Author

@imhele 打算先发一个tslint的简单规则,先用着。

@yesmeck
Copy link
Member

yesmeck commented Mar 11, 2019

这是编译规则,不是 lint 规则

@xiaohuoni
Copy link
Member Author

编译规则是不是在umi的势力范围?

@imhele
Copy link
Contributor

imhele commented Mar 11, 2019

umi 编译 typescript 也是读的 tsconfig.json

@yesmeck
Copy link
Member

yesmeck commented Mar 11, 2019

开启 strict 模式的 TypeScript 才是「真∙TypeScript」

@xiaohuoni
Copy link
Member Author

还没开启 strict 模式,试用了eslint ts🤦‍♂️
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants