Skip to content

Conversation

@ZachDerocher
Copy link

Description

Publishing a test branch for custom feature testing.
sorry for duplicate...
merging into the feature branch instead of main, and with additional update.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@ZachDerocher ZachDerocher changed the title updates to support intensity sensor interoperability with project.py and sensor.py further updates/support for intensity sensor Jul 25, 2025
@ZachDerocher ZachDerocher changed the title further updates/support for intensity sensor test: further updates/support for intensity sensor Jul 25, 2025
@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

❌ Patch coverage is 18.69159% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.50%. Comparing base (b4ffedf) to head (723436c).
⚠️ Report is 1 commits behind head on feat/Intensitysensor.

Files with missing lines Patch % Lines
src/ansys/speos/core/sensor.py 16.50% 86 Missing ⚠️
src/ansys/speos/core/project.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           feat/Intensitysensor     #673      +/-   ##
========================================================
+ Coverage                 85.59%   86.50%   +0.91%     
========================================================
  Files                        39       39              
  Lines                      5942     6040      +98     
========================================================
+ Hits                       5086     5225     +139     
+ Misses                      856      815      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pluAtAnsys pluAtAnsys marked this pull request as draft August 4, 2025 14:05
@ZachDerocher ZachDerocher marked this pull request as ready for review November 14, 2025 11:37
@StefanThoene StefanThoene merged commit 6c58ab0 into feat/Intensitysensor Nov 18, 2025
25 checks passed
@StefanThoene StefanThoene deleted the zd-intensitysensor-testing branch November 18, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants