Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 2, 2026

Description

Implement new GRPC transports

Issue linked

NA

Checklist

Copilot AI review requested due to automatic review settings January 2, 2026 10:33
@germa89 germa89 requested a review from a team as a code owner January 2, 2026 10:33
@germa89 germa89 self-assigned this Jan 2, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements new gRPC transport modes for PyMAPDL, adding support for Unix Domain Sockets (UDS), Windows Named Pipes (WNUA), and mutual TLS (mTLS) alongside the existing insecure transport. The implementation provides automatic transport selection based on platform and allows manual configuration through new parameters.

Key Changes:

  • Added transport mode configuration with automatic platform-based selection (UDS on Linux, WNUA on Windows)
  • Introduced new initialization parameters (transport_mode, uds_dir, uds_id, certs_dir) for transport configuration
  • Integrated ansys.tools.common.cyberchannel for transport verification and channel creation

Reviewed changes

Copilot reviewed 297 out of 298 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/ansys/mapdl/core/mapdl_grpc.py Core implementation of transport modes with configuration methods, channel creation updates, and UDS cleanup logic
src/ansys/mapdl/core/mapdl_core.py Added transport-related parameters to the allowed parameters list
src/ansys/mapdl/core/launcher.py Extended launch_mapdl signature with transport parameters and documentation
pyproject.toml Pinned ansys-tools-common dependency to version 0.3.0
.github/workflows/test-remote.yml Configured test environment to use insecure transport mode
.github/workflows/test-local.yml Configured test environment to use insecure transport mode
.ci/start_mapdl.sh Added environment variable for insecure transport mode
.ci/build_matrix.sh Added new MAPDL version v25.2-pre1-ubuntu-cicd to build matrix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc examples Publishing PyMAPDL examples documentation Documentation related (improving, adding, etc) dependencies maintenance General maintenance of the repo (libraries, cicd, etc) new feature Request or proposal for a new feature labels Jan 2, 2026
@germa89 germa89 changed the title Feat/implement transports feat: implement new gRPC transports Jan 2, 2026
@github-actions github-actions bot removed examples Publishing PyMAPDL examples documentation Documentation related (improving, adding, etc) labels Jan 2, 2026
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

❌ Patch coverage is 86.40777% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.14%. Comparing base (ed40437) to head (fb6c7b9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4354      +/-   ##
==========================================
- Coverage   91.33%   91.14%   -0.19%     
==========================================
  Files         196      196              
  Lines       15977    16076      +99     
==========================================
+ Hits        14592    14652      +60     
- Misses       1385     1424      +39     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89
Copy link
Collaborator Author

germa89 commented Jan 23, 2026

@pyansys-ci-bot LGTM

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit e4d2758 into main Jan 23, 2026
48 of 51 checks passed
@germa89 germa89 deleted the feat/implement-transports branch January 23, 2026 09:30
@germa89
Copy link
Collaborator Author

germa89 commented Jan 23, 2026

I need to fix the minimal installation and add more CICD for other transports such as WNUA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related with CICD, Github Actions, etc dependencies maintenance General maintenance of the repo (libraries, cicd, etc) new feature Request or proposal for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants