Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Dec 11, 2025

Description

As the title.

Issue linked

Close #4292

Checklist

@germa89 germa89 self-assigned this Dec 11, 2025
@germa89 germa89 requested a review from a team as a code owner December 11, 2025 11:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the VTK (Visualization Toolkit) package version from 9.4.2 to 9.5.2 across the project's dependency files to address issue #4292.

Key changes:

  • Updated VTK version constraint in main dependencies from <9.5.0 to <9.5.3
  • Pinned VTK version to 9.5.2 in test and documentation dependencies
  • Synchronized VTK versions across all devcontainer requirement files

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
pyproject.toml Updated VTK version constraint to allow 9.5.x versions and pinned test/doc dependencies to 9.5.2
.devcontainer/devcontainer-local/requirements.txt Updated VTK from 9.3.1 to 9.5.2
.devcontainer/codespaces-docs/requirements.txt Updated VTK from 9.4.2 to 9.5.2
.devcontainer/codespaces-dev/requirements.txt Updated VTK from 9.4.2 to 9.5.2

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc dependencies maintenance General maintenance of the repo (libraries, cicd, etc) enhancement Improve any current implemented feature labels Dec 11, 2025
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.24%. Comparing base (3f6f7f4) to head (305cfc5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4340      +/-   ##
==========================================
- Coverage   91.27%   91.24%   -0.03%     
==========================================
  Files         195      195              
  Lines       15969    15969              
==========================================
- Hits        14575    14571       -4     
- Misses       1394     1398       +4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89
Copy link
Collaborator Author

germa89 commented Dec 11, 2025

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) December 11, 2025 11:45
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 387356e into main Dec 11, 2025
45 of 46 checks passed
@germa89 germa89 deleted the build/update-vtk branch December 11, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related with CICD, Github Actions, etc dependencies enhancement Improve any current implemented feature maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update VTK upper bound to be 9.6.0 inline with the PyVista version

3 participants