fix: "update_coordinates" not found in dcb composite example #4272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes a bug in the DCB composite example where plotter.update_coordinates method calls were failing because the method doesn't exist. The solution replaces these calls with direct assignment to the mesh points.
- Replaced non-existent
plotter.update_coordinates()calls with direct mesh point assignments - Maintained the same functionality while using the correct API
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
github-actions
bot
added
examples
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4272 +/- ##
==========================================
+ Coverage 91.05% 91.27% +0.21%
==========================================
Files 193 193
Lines 15720 15720
==========================================
+ Hits 14314 14348 +34
+ Misses 1406 1372 -34 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@pyansys-ci-bot LGTM. |
clatapie
pushed a commit
that referenced
this pull request
Oct 27, 2025
* fix: "update_coordinates" not found in dcb composite example * chore: adding changelog file 4272.fixed.md [dependabot-skip] --------- Co-authored-by: pyansys-ci-bot <[email protected]>
clatapie
pushed a commit
that referenced
this pull request
Nov 5, 2025
* fix: "update_coordinates" not found in dcb composite example * chore: adding changelog file 4272.fixed.md [dependabot-skip] --------- Co-authored-by: pyansys-ci-bot <[email protected]>
clatapie
pushed a commit
that referenced
this pull request
Nov 18, 2025
* fix: "update_coordinates" not found in dcb composite example * chore: adding changelog file 4272.fixed.md [dependabot-skip] --------- Co-authored-by: pyansys-ci-bot <[email protected]>
clatapie
pushed a commit
that referenced
this pull request
Nov 21, 2025
* fix: "update_coordinates" not found in dcb composite example * chore: adding changelog file 4272.fixed.md [dependabot-skip] --------- Co-authored-by: pyansys-ci-bot <[email protected]>
clatapie
pushed a commit
that referenced
this pull request
Nov 21, 2025
* fix: "update_coordinates" not found in dcb composite example * chore: adding changelog file 4272.fixed.md [dependabot-skip] --------- Co-authored-by: pyansys-ci-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title.
Issue linked
Close #4268
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)