Skip to content

fix(slurm): make get_slurm_options astype optional and preserve default type. #4267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
germa89 merged 4 commits into from
Oct 22, 2025
Merged

fix(slurm): make get_slurm_options astype optional and preserve default type. #4267

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68109f9
fix(slurm): make get_slurm_options astype optional and preserve defau…
germa89 Oct 20, 2025
aa80d4c
Merge branch 'main' into fix/slurm-nodelist-parsing-issue
germa89 Oct 20, 2025
530eae3
chore: adding changelog file 4267.fixed.md [dependabot-skip]
pyansys-ci-bot Oct 20, 2025
f925c8f
fix(slurm): allow non-integer SLURM option values by trying float the…
germa89 Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/ansys/mapdl/core/launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2066,7 +2066,7 @@ def get_value(
variable: str,
kwargs: Dict[str, str],
default: Optional[Union[str, int, float]] = 1,
astype: Optional[Callable[[Any], Any]] = int,
astype: Optional[Callable[[Any], Any]] = None,
) -> str | int | float:
value_from_env_vars = os.environ.get(variable)
value_from_kwargs = kwargs.pop(variable, None)
Expand All @@ -2077,8 +2077,10 @@ def get_value(

if astype and value:
return astype(value)
elif default is not None:
return type(default)(value)
else:
return value
return int(value)

## Getting env vars
SLURM_NNODES = get_value("SLURM_NNODES", kwargs)
Expand Down Expand Up @@ -2112,7 +2114,7 @@ def get_value(
LOG.info(f"SLURM_MEM_PER_NODE: {SLURM_MEM_PER_NODE}")

SLURM_NODELIST = str(
get_value("SLURM_NODELIST", kwargs, default="") # type: ignore
get_value("SLURM_NODELIST", kwargs, default="", astype=str) # type: ignore
).lower() # type: ignore
LOG.info(f"SLURM_NODELIST: {SLURM_NODELIST}")

Expand Down
Loading