-
Notifications
You must be signed in to change notification settings - Fork 142
ci: reducing secret exposure #4261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reduces secret exposure in GitHub Actions workflows by removing unnecessary secret declarations and environment variable configurations.
- Removes unused GITHUB_TOKEN environment variable from migrator workflow
- Removes MeiliSearch API key environment variables from CI workflow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/migrator.yml | Removes unused GITHUB_TOKEN environment variable from git configuration step |
| .github/workflows/ci.yml | Removes MeiliSearch API key environment variables from global environment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4261 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 193 193
Lines 15720 15720
=======================================
Hits 14353 14353
Misses 1367 1367 🚀 New features to boost your workflow:
|
|
@Revathyvenugopal162 can you confirm that MEILISEARCH secrets are not needed? |
|
@germa89 Thanks for removing the token, yes it is no longer required. |
|
@pyansys-ci-bot LGTM |
pyansys-ci-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* ci: remove Meilisearch API keys from CI workflow environment * ci: remove GITHUB_TOKEN env from migrator workflow clone step * chore: adding changelog file 4261.maintenance.md [dependabot-skip] --------- Co-authored-by: pyansys-ci-bot <[email protected]>
* ci: remove Meilisearch API keys from CI workflow environment * ci: remove GITHUB_TOKEN env from migrator workflow clone step * chore: adding changelog file 4261.maintenance.md [dependabot-skip] --------- Co-authored-by: pyansys-ci-bot <[email protected]>
* ci: remove Meilisearch API keys from CI workflow environment * ci: remove GITHUB_TOKEN env from migrator workflow clone step * chore: adding changelog file 4261.maintenance.md [dependabot-skip] --------- Co-authored-by: pyansys-ci-bot <[email protected]>


Description
Reduce secrets
Issue linked
Close #4247
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)