Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 26, 2025

Description

As the title. Using screenshot for all plot methods.
It also simplifies the code reducing duplicity.

Issue linked

Required by #4204

Checklist

Copilot AI review requested due to automatic review settings August 26, 2025 14:17
@germa89 germa89 requested a review from a team as a code owner August 26, 2025 14:17
@github-actions github-actions bot added the new feature Request or proposal for a new feature label Aug 26, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the "PLVA" command to the list of plot commands and refactors the plot handling logic to use the screenshot method consistently for all plot operations.

  • Added "PLVA" to the PLOT_COMMANDS list
  • Simplified plot command handling in the run method by replacing complex conditional logic with a single screenshot call
  • Fixed control flow in the screenshot method by adding proper return statement

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.29%. Comparing base (ec3cb1d) to head (834f743).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4196      +/-   ##
==========================================
- Coverage   91.31%   91.29%   -0.02%     
==========================================
  Files         193      193              
  Lines       15731    15710      -21     
==========================================
- Hits        14364    14343      -21     
  Misses       1367     1367              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89 germa89 changed the title feat: adding plvar to plot commands refactor: use screenshot to show plots Aug 28, 2025
@github-actions github-actions bot added the enhancement Improve any current implemented feature label Aug 28, 2025
@germa89 germa89 enabled auto-merge (squash) August 28, 2025 11:17
@germa89
Copy link
Collaborator Author

germa89 commented Aug 28, 2025

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 04066b1 into main Aug 28, 2025
50 of 56 checks passed
@germa89 germa89 deleted the feat/using-screenshot-instead-to-show-plots branch August 28, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improve any current implemented feature new feature Request or proposal for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants