-
Notifications
You must be signed in to change notification settings - Fork 142
refactor: use screenshot to show plots #4196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the "PLVA" command to the list of plot commands and refactors the plot handling logic to use the screenshot method consistently for all plot operations.
- Added "PLVA" to the PLOT_COMMANDS list
- Simplified plot command handling in the
runmethod by replacing complex conditional logic with a singlescreenshotcall - Fixed control flow in the
screenshotmethod by adding proper return statement
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…/github.com/ansys/pymapdl into feat/using-screenshot-instead-to-show-plots
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4196 +/- ##
==========================================
- Coverage 91.31% 91.29% -0.02%
==========================================
Files 193 193
Lines 15731 15710 -21
==========================================
- Hits 14364 14343 -21
Misses 1367 1367 🚀 New features to boost your workflow:
|
…an do another PR about it
|
@pyansys-ci-bot LGTM. |
pyansys-ci-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Description
As the title. Using
screenshotfor all plot methods.It also simplifies the code reducing duplicity.
Issue linked
Required by #4204
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)