Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 7, 2025

Description

Fix pyvista dependency while we figure out what to do with #4157

Issue linked

Related #4157

Checklist

Copilot AI review requested due to automatic review settings August 7, 2025 09:16
@germa89 germa89 requested a review from a team as a code owner August 7, 2025 09:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the pyvista dependency version to resolve compatibility issues. The change constrains pyvista to version 0.45.2 or lower while a longer-term solution is developed for issue #4157.

  • Adds version constraint to pyvista dependency

@github-actions github-actions bot added dependencies maintenance General maintenance of the repo (libraries, cicd, etc) bug Issue, problem or error in PyMAPDL labels Aug 7, 2025
@germa89 germa89 enabled auto-merge (squash) August 7, 2025 09:34
@germa89
Copy link
Collaborator Author

germa89 commented Aug 7, 2025

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@codecov
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.33%. Comparing base (514cfae) to head (04f9cb6).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4158      +/-   ##
==========================================
+ Coverage   91.30%   91.33%   +0.03%     
==========================================
  Files         189      193       +4     
  Lines       15698    15722      +24     
==========================================
+ Hits        14333    14360      +27     
+ Misses       1365     1362       -3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89 germa89 merged commit 576d2ab into main Aug 7, 2025
45 checks passed
@germa89 germa89 deleted the fix/pyvista-dependency-to-0.45.2 branch August 7, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL dependencies maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants