Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 31, 2025

This reverts commit 502a5e2.

Also update the MAPDL container to use v25.2-ubuntu-amd.

Description

The examples upload files to the DPF docker container, that fails if using ubuntu.

Issue linked

Discovered in #4131
Related to ansys/pydpf-core#2254

Checklist

…tion step in documentation build workflow (#4118)"

This reverts commit 502a5e2.
Copilot AI review requested due to automatic review settings July 31, 2025 08:22
@germa89 germa89 requested a review from a team as a code owner July 31, 2025 08:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request reverts a previous commit that updated the MAPDL image version and removed the DPF server activation step in the documentation build workflow. The reversion is necessary because the examples upload files to the DPF docker container, which fails when using Ubuntu images.

  • Reverts MAPDL image version from v25.2-ubuntu-cicd back to v24.2-ubuntu-student
  • Restores the DPF server activation step with a separate Rocky-based DPF image
  • Removes the changelog entry for the original fix

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
doc/changelog.d/4118.fixed.md Removes the changelog entry for the reverted commit
.github/workflows/doc-build.yml Reverts MAPDL image version and restores DPF server activation step

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Jul 31, 2025
@germa89 germa89 self-assigned this Jul 31, 2025
@germa89
Copy link
Collaborator Author

germa89 commented Jul 31, 2025

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) July 31, 2025 08:26
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.34%. Comparing base (db31b73) to head (090ce25).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4132      +/-   ##
==========================================
- Coverage   91.35%   91.34%   -0.02%     
==========================================
  Files         189      189              
  Lines       15650    15650              
==========================================
- Hits        14297    14295       -2     
- Misses       1353     1355       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89 germa89 changed the title revert: "fix: update MAPDL image version and remove DPF server activation step in documentation build workflow (#4118)" fix: doc build workflow Jul 31, 2025
@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Jul 31, 2025
@germa89 germa89 changed the title fix: doc build workflow fix: doc build workflow by using two containers: MAPDL and DPF Jul 31, 2025
@germa89 germa89 merged commit 1b50886 into main Jul 31, 2025
80 of 81 checks passed
@germa89 germa89 deleted the revert/doc-build-docker-image branch July 31, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants