Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 14, 2025

Description

As the title.

Issue linked

NA

Checklist

Summary by Sourcery

Correct typos and clarify messaging in the GitHub Actions migrator workflow’s success comment.

CI:

  • Refine success notification wording to use “pull request” consistently and reference the original contributor’s login.
  • Clarify branch cloning instructions to use the base branch variable.
  • Add notice that the original PR will be closed by admins soon and conclude with a thank-you message.

@germa89 germa89 self-assigned this Jul 14, 2025
Copilot AI review requested due to automatic review settings July 14, 2025 08:15
@germa89 germa89 requested a review from a team as a code owner July 14, 2025 08:15
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 14, 2025

Reviewer's Guide

This PR refines the success notification in the migrator workflow by correcting typos, clarifying messaging, updating branch references, and standardizing user placeholders for consistency.

File-Level Changes

Change Details Files
Standardize user placeholders and thank-you messages
  • Replaced @${userTriggering} with @${originalPR.user.login} for accurate attribution
  • Added a final thank-you using the updated placeholder
.github/workflows/migrator.yml
Clarify success messaging and administrative notes
  • Changed “The PR” to “The pull request” for clarity
  • Inserted a note that the original PR will be closed by admins soon
  • Rephrased instructions to start work in the new pull request
.github/workflows/migrator.yml
Update branch reference in clone command
  • Swapped git clone flag from ${prHeadBranch} to ${prBaseBranch}
.github/workflows/migrator.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes typos and improves the wording in the success migrator comment that appears when a migration is completed. The changes focus on making the automated message more clear and professional.

Key changes:

  • Corrected terminology from "PR" to "pull request" for clarity
  • Fixed user reference to use the original PR author instead of the triggering user
  • Improved the structure and flow of the migration completion message

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @germa89 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) bug Issue, problem or error in PyMAPDL labels Jul 14, 2025
@germa89
Copy link
Collaborator Author

germa89 commented Jul 14, 2025

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) July 14, 2025 08:21
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@codecov
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (a9d37dc) to head (8283600).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4096      +/-   ##
==========================================
+ Coverage   91.82%   91.85%   +0.03%     
==========================================
  Files         187      187              
  Lines       15033    15033              
==========================================
+ Hits        13804    13809       +5     
+ Misses       1229     1224       -5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89 germa89 merged commit c7f3ad6 into main Jul 14, 2025
45 checks passed
@germa89 germa89 deleted the fix/migrator-success-message branch July 14, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants