-
Notifications
You must be signed in to change notification settings - Fork 142
fix: add curl installation to fix codecov upload #4070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideUpdated CI test-local workflow to install curl, ensuring the codecov upload script can run successfully. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR ensures curl is installed in the CI environment so that the Codecov upload script can run successfully.
- Added
curlto the list of OS packages for minimal and full testing workflows. - Retained cleanup commands after installation.
Comments suppressed due to low confidence (2)
.github/workflows/test-local.yml:179
- [nitpick] Consider using
apt-get install -y --no-install-recommendsand cleaning up/var/lib/apt/lists/*(e.g.,rm -rf /var/lib/apt/lists/*) to reduce the image footprint.
apt-get update && apt install -y libgomp1 graphviz curl && apt-get clean
.github/workflows/test-local.yml:185
- [nitpick] Similarly, for consistency and smaller CI environments, use
--no-install-recommendsand remove APT lists after installation.
apt-get update && apt install -y libgl1-mesa-glx xvfb libgomp1 graphviz curl && apt-get clean
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4070 +/- ##
==========================================
+ Coverage 89.02% 91.80% +2.77%
==========================================
Files 187 187
Lines 14993 14993
==========================================
+ Hits 13348 13764 +416
+ Misses 1645 1229 -416 🚀 New features to boost your workflow:
|
|
@pyansys-ci-bot LGTM. |
pyansys-ci-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Description
I realised that the local testing coverage results weren't being uploaded to codecov. See the log:
Link: https://github.com/ansys/pymapdl/actions/runs/16023515132/job/45206036644?pr=1300#step:20:360
Issue linked
NA
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)Summary by Sourcery
Install curl in the GitHub Actions test-local workflow to fix Codecov upload failures.
Bug Fixes:
CI: