Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 2, 2025

Description

I realised that the local testing coverage results weren't being uploaded to codecov. See the log:

==> Detected linux
 -> Downloading https://cli.codecov.io/latest/linux/codecov
/__w/_actions/codecov/codecov-action/v5/dist/codecov.sh: line 92: curl: command not found
==> Finishing downloading linux:latest
/__w/_actions/codecov/codecov-action/v5/dist/codecov.sh: line 95: curl: command not found
      Version: 

/__w/_actions/codecov/codecov-action/v5/dist/codecov.sh: line 103: curl: command not found
gpg: directory '/github/home/.gnupg' created
gpg: keybox '/github/home/.gnupg/pubring.kbx' created
gpg: no valid OpenPGP data found.
gpg: Total number processed: 0
==> Verifying GPG signature integrity
 -> Downloading https://cli.codecov.io/latest/linux/codecov.SHA256SUM
 -> Downloading https://cli.codecov.io/latest/linux/codecov.SHA256SUM.sig

/__w/_actions/codecov/codecov-action/v5/dist/codecov.sh: line 114: curl: command not found
/__w/_actions/codecov/codecov-action/v5/dist/codecov.sh: line 115: curl: command not found
gpg: can't open 'codecov.SHA256SUM.sig': No such file or directory
gpg: verify signatures failed: No such file or directory
==> Could not verify signature. Please contact Codecov if problem continues
sha256sum: codecov.SHA256SUM: No such file or directory
==> Could not verify SHASUM. Please contact Codecov if problem continues
==> CLI integrity verified

chmod: cannot access './codecov': No such file or directory
 -> Token of length 36 detected
==> Running upload-coverage
      ./codecov  upload-coverage -t <redacted> --git-service github --sha 72b499808af5b777a7c2aa407e238fc61fafec34 --flag ubuntu --flag local --flag v25.2-ubuntu-cicd --flag local --flag non-student --flag dmp --gcov-executable gcov --name local-v25.2-ubuntu-cicd.xml --network-root-folder /__w/pymapdl/pymapdl
/__w/_actions/codecov/codecov-action/v5/dist/codecov.sh: line 253: ./codecov: No such file or directory

Link: https://github.com/ansys/pymapdl/actions/runs/16023515132/job/45206036644?pr=1300#step:20:360

Issue linked

NA

Checklist

Summary by Sourcery

Install curl in the GitHub Actions test-local workflow to fix Codecov upload failures.

Bug Fixes:

  • Add curl to apt install commands to resolve 'curl: command not found' errors during Codecov downloads.

CI:

  • Include curl in OS package installation steps for both minimal and non-minimal testing configurations.

Copilot AI review requested due to automatic review settings July 2, 2025 11:47
@germa89 germa89 requested a review from a team as a code owner July 2, 2025 11:47
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 2, 2025

Reviewer's Guide

Updated CI test-local workflow to install curl, ensuring the codecov upload script can run successfully.

File-Level Changes

Change Details Files
Add curl package installation to CI workflow
  • Include 'curl' in minimal testing apt-get install command
  • Include 'curl' in full testing apt-get install command
.github/workflows/test-local.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@germa89 germa89 self-assigned this Jul 2, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @germa89 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures curl is installed in the CI environment so that the Codecov upload script can run successfully.

  • Added curl to the list of OS packages for minimal and full testing workflows.
  • Retained cleanup commands after installation.
Comments suppressed due to low confidence (2)

.github/workflows/test-local.yml:179

  • [nitpick] Consider using apt-get install -y --no-install-recommends and cleaning up /var/lib/apt/lists/* (e.g., rm -rf /var/lib/apt/lists/*) to reduce the image footprint.
          apt-get update && apt install -y libgomp1 graphviz curl && apt-get clean

.github/workflows/test-local.yml:185

  • [nitpick] Similarly, for consistency and smaller CI environments, use --no-install-recommends and remove APT lists after installation.
          apt-get update && apt install -y libgl1-mesa-glx xvfb libgomp1 graphviz curl && apt-get clean

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) bug Issue, problem or error in PyMAPDL labels Jul 2, 2025
@codecov
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.80%. Comparing base (eaf5df4) to head (b72e65b).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4070      +/-   ##
==========================================
+ Coverage   89.02%   91.80%   +2.77%     
==========================================
  Files         187      187              
  Lines       14993    14993              
==========================================
+ Hits        13348    13764     +416     
+ Misses       1645     1229     -416     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89 germa89 enabled auto-merge (squash) July 2, 2025 12:08
@germa89 germa89 disabled auto-merge July 2, 2025 12:08
@germa89 germa89 enabled auto-merge (squash) July 2, 2025 13:42
@germa89
Copy link
Collaborator Author

germa89 commented Jul 2, 2025

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 4aad52c into main Jul 2, 2025
77 of 80 checks passed
@germa89 germa89 deleted the ci/fix-coverage-upload branch July 2, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants