Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Jun 26, 2025

Description

As the title, to close #4041

Issue linked

#4041

Checklist

Summary by Sourcery

Bug Fixes:

  • Limit ansys-tools-visualization-interface dependency to <0.10.0 in the graphics and all extra requirements

@germa89 germa89 requested a review from a team as a code owner June 26, 2025 08:44
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 26, 2025

Reviewer's Guide

Updates the dependency constraints for ansys-tools-visualization-interface in pyproject.toml by adding an upper version bound (<0.10.0) to both the graphics and all extras to prevent incompatible releases (closes #4041).

File-Level Changes

Change Details Files
Restrict ansys-tools-visualization-interface version range
  • Add <0.10.0 upper bound to graphics extra dependency
  • Add <0.10.0 upper bound to all extra dependency
pyproject.toml

Assessment against linked issues

Issue Objective Addressed Explanation
#4041 Resolve the issue where plotting commands (aplot, lplot, etc.) fail in PyMAPDL, preventing geometry visualization.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added dependencies maintenance General maintenance of the repo (libraries, cicd, etc) bug Issue, problem or error in PyMAPDL labels Jun 26, 2025
@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.13%. Comparing base (ae37909) to head (e143c3f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4042      +/-   ##
==========================================
- Coverage   89.18%   89.13%   -0.05%     
==========================================
  Files         187      187              
  Lines       14983    14993      +10     
==========================================
+ Hits        13362    13364       +2     
- Misses       1621     1629       +8     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89 germa89 enabled auto-merge (squash) June 26, 2025 09:17
@germa89
Copy link
Collaborator Author

germa89 commented Jun 26, 2025

@pyansys-ci-bot LGTM.

@germa89 germa89 self-assigned this Jun 26, 2025
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 disabled auto-merge June 26, 2025 09:18
@germa89 germa89 merged commit fdbc9ad into main Jun 26, 2025
48 checks passed
@germa89 germa89 deleted the build/ping-ansys-viz branch June 26, 2025 10:00
germa89 added a commit that referenced this pull request Jun 26, 2025
* fix: restrict ansys-tools-visualization-interface version range

* chore: adding changelog file 4042.fixed.md [dependabot-skip]

---------

Co-authored-by: pyansys-ci-bot <[email protected]>
@germa89
Copy link
Collaborator Author

germa89 commented Jun 26, 2025

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL dependencies maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to plot geometry

4 participants