Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Jun 25, 2025

Description

As the title.

Issue linked

Close #4033

Checklist

Summary by Sourcery

Build:

  • Constrain vtk dependency to ">=9.0.0,<9.5.0" in pyproject.toml

@germa89 germa89 requested a review from a team as a code owner June 25, 2025 10:36
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 25, 2025

Reviewer's Guide

This PR updates the project’s VTK dependency to cap the version below 9.5.0, ensuring compatibility with existing code paths.

File-Level Changes

Change Details Files
Restrict VTK dependency version range
  • Changed vtk requirement from ">=9.0.0" to ">=9.0.0,<9.5.0"
pyproject.toml

Assessment against linked issues

Issue Objective Addressed Explanation
#4033 Fix the ImportError caused by the removal of vtkCapsuleSource in VTK version 9.5.0 when installing ansys.mapdl.core.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added dependencies maintenance General maintenance of the repo (libraries, cicd, etc) labels Jun 25, 2025
@germa89
Copy link
Collaborator Author

germa89 commented Jun 25, 2025

I am going to merge this because I need to work on #1300. Once Pyvista has made a release I will undo this.

@germa89 germa89 enabled auto-merge (squash) June 25, 2025 10:51
@germa89
Copy link
Collaborator Author

germa89 commented Jun 25, 2025

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.12%. Comparing base (53ad87c) to head (5793cb7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4034      +/-   ##
==========================================
+ Coverage   89.05%   89.12%   +0.07%     
==========================================
  Files         187      187              
  Lines       14970    14970              
==========================================
+ Hits        13331    13342      +11     
+ Misses       1639     1628      -11     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89 germa89 merged commit 96d8836 into main Jun 25, 2025
44 checks passed
@germa89 germa89 deleted the fix/vtk-version-to-avoid-vtkCapsuleSource-import-issue branch June 25, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'vtkCapsuleSource' from 'vtkmodules.vtkFiltersSources'

3 participants