-
Notifications
You must be signed in to change notification settings - Fork 142
fix: (migrated PR 4027): Added missing kwargs to the dmpoption command. #4030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR adds two new keyword arguments, rescombfreq and deleopt, to the dmpoption method to enable configuring result-combination frequency and local file deletion, updates the docstring with descriptions for these options, and adjusts the command string to include the new parameters. Class diagram for updated dmpoption method signatureclassDiagram
class SolutionAnalysisOptions {
+dmpoption(filetype="", combine="", rescombfreq="", deleopt="", **kwargs)
}
Flow diagram for DMPOPTION command construction with new parametersflowchart TD
A[Call dmpoption method] --> B[Build DMPOPTION command string]
B --> C{Include parameters}
C -->|filetype| D1[Add filetype]
C -->|combine| D2[Add combine]
C -->|rescombfreq| D3[Add rescombfreq]
C -->|deleopt| D4[Add deleopt]
D1 & D2 & D3 & D4 --> E[Run command with constructed string]
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4030 +/- ##
==========================================
+ Coverage 89.05% 89.12% +0.07%
==========================================
Files 187 187
Lines 14970 14970
==========================================
+ Hits 13331 13342 +11
+ Misses 1639 1628 -11 🚀 New features to boost your workflow:
|
|
Close #4027 |
This PR is a mirror pull request created from fix: Added missing kwargs to the dmpoption command. to allow the code to access PyMAPDL CICD secrets.
Check the original PR made by @mbbatukan for more details.
Closes #4027
Original pull request
fix: Added missing kwargs to the dmpoption command.
Description
Please provide a brief description of the changes made in this pull request.
Added missing kwargs to the dmpoption command.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
It is a very minor fix. Please see the changes and refer to the documentation: https://ansyshelp.ansys.com/public/account/secured?returnurl=/Views/Secured/corp/v242/en/ans_cmd/Hlp_C_DMPOPTION.html
Summary by Sourcery
Add missing distributed memory file options to the DMPOPTION command
Bug Fixes:
Documentation: