-
Notifications
You must be signed in to change notification settings - Fork 142
fix: patch in testing #4010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: patch in testing #4010
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideThis PR updates test patches to align with the renamed version extraction function in ansys.tools.path.path, replacing all references to the deprecated “_mapdl_version_from_path” with the new “_version_from_path” and introducing side_effect in one test to better simulate version errors. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
@pyansys-ci-bot LGTM. |
pyansys-ci-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4010 +/- ##
==========================================
- Coverage 89.17% 89.12% -0.05%
==========================================
Files 187 187
Lines 14970 14970
==========================================
- Hits 13349 13342 -7
- Misses 1621 1628 +7 🚀 New features to boost your workflow:
|

Description
Recently we have seen some exceptions when trying to patch inexisting methods or attributes. This wasnt an issue before, but I guess something changed in #3987 or in #4005. I couldnt really figure out where. I guess it was in #3987.
Issue linked
NA
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)Summary by Sourcery
Fix mock patching of ansys.tools.path.path version retrieval in tests to match renamed function.
Bug Fixes: