-
Notifications
You must be signed in to change notification settings - Fork 142
ci: allow starting DPF on same container #4008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideThis PR enhances the GitHub CI workflow to support starting the DPF server either on the same container (for 'cicd' versions) or on a separate container, and adjusts the build matrix script to ensure 'cicd' versions are not skipped in remote runs. Flow Diagram: Updated Build Matrix Logic for Remote Non-Student Version Selectiongraph TD
Start["Input: A version to evaluate in build_matrix.sh"] --> IsRemoteAndNotStudent{"Context: Remote Run (ON_REMOTE=true)<br/>AND Non-Student (ON_STUDENT=false)?"};
IsRemoteAndNotStudent -- "Yes (Logic changed by PR)" --> CheckCicd{"Version string contains 'cicd'?"};
IsRemoteAndNotStudent -- "No (e.g. local run, or student version)" --> OtherLogic["Handled by existing/other logic (not shown)"];
CheckCicd -- "Yes" --> IncludeVersion["Action: Include version in build<br/>(Not Skipped)"];
CheckCicd -- "No" --> SkipVersion["Action: Skip this version for the build"];
IncludeVersion --> EndEval["End evaluation for this version"];
SkipVersion --> EndEval;
OtherLogic --> EndEval;
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @germa89 - I've reviewed your changes - here's some feedback:
- Consider refactoring the two ‘Start DPF server…’ steps into a single step with conditional logic or YAML anchors to reduce duplication and improve maintainability.
- Move the ON_SAME_CONTAINER detection and export logic up into a shared env block or step to avoid scattering environment variable assignments.
- Simplify the build_matrix.sh version check by combining the cicd version exception into the primary remote/student condition, reducing nested if/elif branches.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider refactoring the two ‘Start DPF server…’ steps into a single step with conditional logic or YAML anchors to reduce duplication and improve maintainability.
- Move the ON_SAME_CONTAINER detection and export logic up into a shared env block or step to avoid scattering environment variable assignments.
- Simplify the build_matrix.sh version check by combining the cicd version exception into the primary remote/student condition, reducing nested if/elif branches.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4008 +/- ##
==========================================
- Coverage 89.17% 89.12% -0.05%
==========================================
Files 187 187
Lines 14970 14970
==========================================
- Hits 13349 13342 -7
- Misses 1621 1628 +7 🚀 New features to boost your workflow:
|
|
@pyansys-ci-bot LGTM. |
pyansys-ci-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Description
As the title.
Issue linked
Required by #1300
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)Summary by Sourcery
Enable starting the DPF server on the same container for CICD images by adding an ON_SAME_CONTAINER flag and branching CI steps accordingly.
New Features:
Enhancements:
Build:
CI: