Skip to content

fix: selection on non-interactive #3998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
germa89 merged 8 commits into from
Jun 10, 2025
Merged

fix: selection on non-interactive #3998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ae022b7
fix: ensure command execution in interactive mode when storing commands
germa89 Jun 10, 2025
c036f23
test: add parameterized test for selection on non-interactive mode
germa89 Jun 10, 2025
c4ae15c
chore: adding changelog file 3998.miscellaneous.md [dependabot-skip]
pyansys-ci-bot Jun 10, 2025
ab30d6f
refactor: clarify non-interactive mode behavior in command execution …
germa89 Jun 10, 2025
52b2148
Merge branch 'fix/selection-on-non-interactive' of https://github.com…
germa89 Jun 10, 2025
6bfa1e7
test: parameterize selection tests for non-interactive mode
germa89 Jun 10, 2025
96a4454
test: refactor selection tests for non-interactive mode into a class-…
germa89 Jun 10, 2025
7830b78
chore: adding changelog file 3998.miscellaneous.md [dependabot-skip]
pyansys-ci-bot Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/3998.miscellaneous.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix: selection on non-interactive
4 changes: 2 additions & 2 deletions src/ansys/mapdl/core/mapdl_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1360,8 +1360,8 @@ def wrap_xsel_function_output(method):
def inner_wrapper(*args, **kwargs):
# in interactive mode (item='p'), the output is not suppressed
if self._store_commands:
# In non-interactive mode, we do not need to check anything.
return
# In non-interactive mode, execute the wrapped function and return its result.
return func(*args, **kwargs)

is_interactive_arg = (
True
Expand Down
53 changes: 51 additions & 2 deletions tests/test_mapdl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,12 +381,12 @@ def test_empty(mapdl, cleared):
mapdl.run("")


def test_multiline_fail(mapdl, cleared):
def test_multiline_fail_value_error(mapdl, cleared):
with pytest.raises(ValueError, match="Use ``input_strings``"):
mapdl.run(CMD_BLOCK)


def test_multiline_fail(mapdl, cleared):
def test_multiline_fail_deprecation_warning(mapdl, cleared):
with pytest.warns(DeprecationWarning):
resp = mapdl.run_multiline(CMD_BLOCK)
assert "IS SOLID186" in resp, "not capturing the beginning of the block"
Expand Down Expand Up @@ -3007,3 +3007,52 @@ def test_set_no_abort(monkeypatch, set_no_abort, start_instance):

if set_no_abort is None or set_no_abort:
assert any(["/NERR,,,-1" in each for each in calls])


class TestSelectionOnNonInteractive:
"""Test selection commands in non-interactive mode."""

@pytest.fixture(scope="class", autouse=True)
def setup(self, mapdl):
self.mapdl = mapdl

mapdl.clear()
mapdl.prep7()
mapdl.block(0, 1, 0, 1, 0, 1)
mapdl.et(1, 186)
mapdl.esize(0.25)
mapdl.vmesh("ALL")

@pytest.mark.parametrize("func", ["nsel", "esel", "ksel", "lsel", "asel"])
@pytest.mark.parametrize("sel_type", ["S", "R", "U", "A"])
def test_selection_on_non_interactive(self, mapdl, func, sel_type):
mapdl.allsel()

function = getattr(mapdl, func)

if func == "nsel":
checker = lambda: mapdl.mesh.nnum
elif func == "esel":
checker = lambda: mapdl.mesh.enum
elif func == "ksel":
checker = lambda: mapdl.geometry.knum
elif func == "lsel":
checker = lambda: mapdl.geometry.lnum
elif func == "asel":
checker = lambda: mapdl.geometry.anum

function("S", vmin=1, vmax=3)
assert np.allclose(checker(), [1, 2, 3])

with mapdl.non_interactive:
if sel_type == "A":
function(sel_type, vmin=5)
else:
function(sel_type, vmin=2)

if sel_type in ["S", "R"]:
assert np.allclose(checker(), [2])
elif sel_type == "U":
assert np.allclose(checker(), [1, 3])
elif sel_type == "A":
assert np.allclose(checker(), [1, 2, 3, 5])
Loading