-
Notifications
You must be signed in to change notification settings - Fork 142
fix: selection on non-interactive #3998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideRestore command execution in non-interactive mode by modifying the inner_wrapper early return to call the wrapped function, and improve test coverage by renaming existing tests for clarity and adding a parameterized test for node selection under non-interactive conditions. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @germa89 - I've reviewed your changes - here's some feedback:
- Consider renaming
_store_commandsto something like_non_interactive_modeor_deferred_executionto better reflect its purpose and improve readability. - Add analogous tests for other selection methods (e.g.
esel,csel) to ensure this non‐interactive execution fix applies consistently across all *_sel commands. - Ensure the non_interactive context manager fully restores the original interactive state on exit so that selection state doesn’t leak into subsequent operations.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…and simplify selection condition in tests
…/ansys/pymapdl into fix/selection-on-non-interactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3998 +/- ##
==========================================
+ Coverage 89.11% 89.12% +0.01%
==========================================
Files 187 187
Lines 14970 14970
==========================================
+ Hits 13340 13342 +2
+ Misses 1630 1628 -2 🚀 New features to boost your workflow:
|
|
@pyansys-ci-bot LGTM. |
pyansys-ci-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* fix: ensure command execution in interactive mode when storing commands * test: add parameterized test for selection on non-interactive mode * chore: adding changelog file 3998.miscellaneous.md [dependabot-skip] * refactor: clarify non-interactive mode behavior in command execution and simplify selection condition in tests * test: parameterize selection tests for non-interactive mode * test: refactor selection tests for non-interactive mode into a class-based structure --------- Co-authored-by: pyansys-ci-bot <[email protected]>

Description
Fix not running xsel commands in non_interactive.
Issue linked
Close #3989
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)Summary by Sourcery
Fix selection commands not executing in non-interactive mode and update related tests.
Bug Fixes:
Tests: