-
Notifications
You must be signed in to change notification settings - Fork 142
feat: add invopt method to enable or disable inverse solving for load steps #3979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideThis pull request introduces the INVOPT command wrapper to the AnalysisOptions class, enabling users to toggle inverse solving on a per‐load‐step basis. The implementation adds a new method following existing patterns, includes parameter validation via docstring, and leverages the generic run() interface. Corresponding unit tests and documentation updates ensure coverage and reflect the new feature. Sequence Diagram for INVOPT Command ExecutionsequenceDiagram
actor User
User->>AnalysisOptions: invopt(option="ON")
AnalysisOptions->>MAPDL: run("INVOPT,ON")
MAPDL-->>AnalysisOptions: ExecutionResult
AnalysisOptions-->>User: ExecutionResult
Updated Class Diagram for AnalysisOptionsclassDiagram
class AnalysisOptions {
+invopt(option: string) : object
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @germa89 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3979 +/- ##
==========================================
- Coverage 88.26% 88.25% -0.02%
==========================================
Files 187 187
Lines 14941 14943 +2
==========================================
Hits 13188 13188
- Misses 1753 1755 +2 🚀 New features to boost your workflow:
|
|
@pyansys-ci-bot LGTM. |
pyansys-ci-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Description
Adding INVOPT command.
Issue linked
Close #3976
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)Summary by Sourcery
New Features:
invoptmethod to toggle inverse solving for static analysis load steps