-
Notifications
You must be signed in to change notification settings - Fork 142
fix: eqslv not being properly converted. #3978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideThis PR ensures the Sequence Diagram: EQSLV Command Conversion Before and After FixsequenceDiagram
actor UserScript
participant PyMapdlCore
participant ConverterModule
participant AnsysMAPDL
UserScript->>PyMapdlCore: mapdl.eqslv(...)
PyMapdlCore->>ConverterModule: convert_command("EQSLV")
alt Before PR (EQSLV not properly converted)
ConverterModule-->>PyMapdlCore: Error or Unhandled Command
PyMapdlCore-->>UserScript: Failure (e.g., CommandException)
else After PR (EQSLV is now recognized)
ConverterModule->>ConverterModule: Lookup "EQSL" (SUCCESS)
ConverterModule-->>PyMapdlCore: Converted/Validated Command
PyMapdlCore->>AnsysMAPDL: Execute on MAPDL instance
AnsysMAPDL-->>PyMapdlCore: Execution Result
PyMapdlCore-->>UserScript: Success
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @germa89 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3978 +/- ##
==========================================
- Coverage 88.26% 88.26% -0.01%
==========================================
Files 187 187
Lines 14941 14941
==========================================
- Hits 13188 13187 -1
- Misses 1753 1754 +1 🚀 New features to boost your workflow:
|
|
@pyansys-ci-bot LGTM. |
pyansys-ci-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Description
Avoid
EQSLVconversion in the converter module.Issue linked
Close #3977
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)Summary by Sourcery
Avoid automatic conversion of the EQSLV command in the converter module and clean up the eqslv command’s documentation formatting.
Bug Fixes:
Enhancements: