-
Notifications
You must be signed in to change notification settings - Fork 142
ci: using strict markers on pytest #3934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideEnforce strict pytest marker usage by updating configuration, standardizing marker names, migrating a deprecated hook decorator, and correcting an expected-failure marker in tests. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @germa89 - I've reviewed your changes - here's some feedback:
- Under
--strict-markers, you’ll need to declarexfail(and any other custom markers you’re using) in themarkerslist, otherwise pytest will error on unknown markers. - The new
consolemarker name may be ambiguous—consider renaming it to something likerequires_consolefor consistency withrequires_gui. - Switching to
@pytest.hookimpl(trylast=True)relies on a newer pytest API—double-check your minimum pytest version in CI to avoid compatibility issues.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…e pytest arguments to enforce strict markers in workflows
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3934 +/- ##
==========================================
- Coverage 88.29% 88.27% -0.03%
==========================================
Files 187 187
Lines 14830 14830
==========================================
- Hits 13094 13091 -3
- Misses 1736 1739 +3 🚀 New features to boost your workflow:
|
…d of 'use_mesh' to avoid warning
|
@pyansys-ci-bot LGTM |
pyansys-ci-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Description
To catch warnings
Issue linked
NA
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)Summary by Sourcery
Enforce strict pytest markers and update test marking conventions throughout the suite
CI:
Tests: