-
Notifications
You must be signed in to change notification settings - Fork 142
refactor: update geometry tests #3930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideThis PR refactors the CAD geometry import tests to first upload CAD files via mapdl.upload before invoking import routines and replaces the generic ON_CI flag with an explicit os.name POSIX check for improved platform detection. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @germa89 - I've reviewed your changes - here's some feedback:
- You’re repeating
mapdl.upload(...)in each CAD format test—consider moving this into a shared fixture or helper function (or using pytest.mark.parametrize) to reduce duplication. - The switch from
ON_CItoos.name == 'posix'may be too broad—if the intent is to skip only CI environments, use a more targeted check (e.g. a CI-specific env var) or add a comment explaining why all POSIX platforms should behave differently.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (80.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3930 +/- ##
==========================================
- Coverage 88.29% 88.27% -0.02%
==========================================
Files 187 187
Lines 14830 14840 +10
==========================================
+ Hits 13094 13100 +6
- Misses 1736 1740 +4 🚀 New features to boost your workflow:
|
|
I am going to settle for this @pyansys-ci-bot LGTM. |
pyansys-ci-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@dts12263 shared with me some catiav4 and catiav5 examples for future testing. |

Description
Small changes to the CAD tests.
Issue linked
Close #3929
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)Summary by Sourcery
Refactor geometry import tests to explicitly upload CAD files before import and update the CATIA V5 import conditional to use os.name for platform detection.
Tests: