-
Notifications
You must be signed in to change notification settings - Fork 142
fix: Change the mapdl_inprocess graphics backend #3915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideThis pull request updates the Class Diagram: Update to MapdlCore for Graphics Backend HandlingclassDiagram
class MapdlCore {
+__init__(self, ..., graphics_backend: Optional[GraphicsBackend] = None, **kwargs)
- _graphics_backend: GraphicsBackend
# Other methods and attributes...
}
class GraphicsBackend {
<<enumeration>>
PYVISTA
MAPDL
NONE
# Potentially other enum values
}
MapdlCore ..> GraphicsBackend : uses
note for MapdlCore "__init__ method updated:\nPrevents ModuleNotFoundError if 'graphics_backend' is GraphicsBackend.MAPDL,\neven when optional graphics dependencies are not installed."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @koubaa - I've reviewed your changes - here's some feedback:
- When
graphics_backendisGraphicsBackend.MAPDLand PyVista is unavailable, ensureself._graphics_backendis explicitly assigned toGraphicsBackend.MAPDLto fully enable its functionality, not just bypass the error.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
`mapdl_inprocess` should use `None`for graphics backend. This will have to be revisited with some automated tests when 2025R2 is released.
2efb018 to
d506984
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3915 +/- ##
==========================================
- Coverage 88.28% 88.27% -0.01%
==========================================
Files 187 187
Lines 14830 14830
==========================================
- Hits 13092 13091 -1
- Misses 1738 1739 +1 🚀 New features to boost your workflow:
|
germa89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #3916
mapdl_inprocessshould useNonefor graphics backend. This will have to be revisited with some automated tests when 2025R2 is released.