Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented May 7, 2025

Description

As the title.

Issue linked

Close #2435

Checklist

@germa89 germa89 requested a review from a team as a code owner May 7, 2025 08:41
@germa89 germa89 requested review from clatapie and pyansys-ci-bot May 7, 2025 08:41
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 7, 2025

Reviewer's Guide

This pull request removes pytest.mark.xfail decorators from several tests across various test files. This was achieved by deleting the specific decorator lines above the test function definitions, indicating that these tests are now expected to pass.

File-Level Changes

Change Details Files
Removed xfail markers from tests previously marked as flaky or failing.
  • Deleted @pytest.mark.xfail(...) decorators from test_remove_temp_dir_on_exit and test_remove_temp_dir_on_exit_with_launch_mapdl.
  • Deleted @pytest.mark.xfail(...) decorator from test_readin_catiav5.
  • Deleted @pytest.mark.xfail(...) decorator from test_map_timeout.
  • Deleted @pytest.mark.xfail(...) decorator from test_extract.
tests/test_mapdl.py
tests/test_importing_geometries.py
tests/test_pool.py
tests/test_xpl.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label May 7, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @germa89 - I've reviewed your changes - here's some feedback:

  • Link to the resolved issues (e.g., #2435, #2377) in the PR description to justify removing these xfail markers.
  • If this PR only removes xfail markers due to fixes elsewhere, consider using 'chore:' as the commit type prefix instead of 'fix:'.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@germa89 germa89 changed the title fix: remove xfail markers from most flaky tests chore: remove xfail markers from most flaky tests May 7, 2025
@github-actions github-actions bot added the enhancement Improve any current implemented feature label May 7, 2025
@germa89 germa89 mentioned this pull request May 7, 2025
3 tasks
@germa89
Copy link
Collaborator Author

germa89 commented May 7, 2025

First run goes well. Let's rerun by merging main.

@germa89
Copy link
Collaborator Author

germa89 commented May 7, 2025

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) May 7, 2025 15:04
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@codecov
Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.28%. Comparing base (1b1b6b4) to head (cbb4e37).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3899      +/-   ##
==========================================
- Coverage   88.29%   88.28%   -0.02%     
==========================================
  Files         187      187              
  Lines       14830    14830              
==========================================
- Hits        13094    13092       -2     
- Misses       1736     1738       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89 germa89 linked an issue May 8, 2025 that may be closed by this pull request
3 tasks
@germa89 germa89 self-assigned this May 8, 2025
@germa89 germa89 disabled auto-merge May 8, 2025 13:58
@germa89 germa89 enabled auto-merge (squash) May 8, 2025 14:26
@germa89 germa89 merged commit 8809b5a into main May 8, 2025
45 checks passed
@germa89 germa89 deleted the tests/removing-some-xpasses-test branch May 8, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL enhancement Improve any current implemented feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky tests

3 participants