-
Notifications
You must be signed in to change notification settings - Fork 142
chore: remove xfail markers from most flaky tests #3899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis pull request removes File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @germa89 - I've reviewed your changes - here's some feedback:
- Link to the resolved issues (e.g., #2435, #2377) in the PR description to justify removing these
xfailmarkers. - If this PR only removes
xfailmarkers due to fixes elsewhere, consider using 'chore:' as the commit type prefix instead of 'fix:'.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
First run goes well. Let's rerun by merging main. |
|
@pyansys-ci-bot LGTM. |
pyansys-ci-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3899 +/- ##
==========================================
- Coverage 88.29% 88.28% -0.02%
==========================================
Files 187 187
Lines 14830 14830
==========================================
- Hits 13094 13092 -2
- Misses 1736 1738 +2 🚀 New features to boost your workflow:
|

Description
As the title.
Issue linked
Close #2435
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)